You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/10/31 17:59:21 UTC

[GitHub] [pulsar] sijie commented on a change in pull request #5463: Function runtime pluggable

sijie commented on a change in pull request #5463: Function runtime pluggable
URL: https://github.com/apache/pulsar/pull/5463#discussion_r341286827
 
 

 ##########
 File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/worker/WorkerConfig.java
 ##########
 @@ -328,162 +332,20 @@ public boolean getTlsEnabled() {
     }
 
 
-    @Data
 
 Review comment:
   Removing configuration is usually treated as a breaking change. Can we keep the old configuration settings for one release but deprecate them? Then after a few more releases, we can remove the settings. Otherwise, it is painful for people to upgrade a cluster.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services