You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by ke...@apache.org on 2016/12/08 18:09:46 UTC
[09/13] incubator-beam git commit: No longer reject timers in ParDo
No longer reject timers in ParDo
Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/c22e2a43
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/c22e2a43
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/c22e2a43
Branch: refs/heads/master
Commit: c22e2a435113c9653b58f1040a4e9266059767f4
Parents: 274f17f
Author: Kenneth Knowles <kl...@google.com>
Authored: Wed Dec 7 20:04:51 2016 -0800
Committer: Kenneth Knowles <kl...@google.com>
Committed: Thu Dec 8 09:53:08 2016 -0800
----------------------------------------------------------------------
.../main/java/org/apache/beam/sdk/transforms/ParDo.java | 10 ----------
1 file changed, 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/c22e2a43/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java
index 4f7491e..e60c536 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java
@@ -594,16 +594,6 @@ public class ParDo {
private static <InputT, OutputT> void validate(DoFn<InputT, OutputT> fn) {
DoFnSignature signature = DoFnSignatures.getSignature((Class) fn.getClass());
- // To be removed when the features are complete and runners have their own adequate
- // rejection logic
- if (!signature.timerDeclarations().isEmpty()) {
- throw new UnsupportedOperationException(
- String.format("Found %s annotations on %s, but %s cannot yet be used with timers.",
- DoFn.TimerId.class.getSimpleName(),
- fn.getClass().getName(),
- DoFn.class.getSimpleName()));
- }
-
// State is semantically incompatible with splitting
if (!signature.stateDeclarations().isEmpty() && signature.processElement().isSplittable()) {
throw new UnsupportedOperationException(