You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/05/07 13:22:34 UTC
[GitHub] [activemq-artemis] andytaylor opened a new pull request #3121: ARTEMIS-2749 - Broadcast Group Control Improvements
andytaylor opened a new pull request #3121:
URL: https://github.com/apache/activemq-artemis/pull/3121
added some default behaviour for when overridden
https://issues.apache.org/jira/browse/ARTEMIS-2749
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] andytaylor commented on a change in pull request #3121: ARTEMIS-2749 - Broadcast Group Control Improvements
Posted by GitBox <gi...@apache.org>.
andytaylor commented on a change in pull request #3121:
URL: https://github.com/apache/activemq-artemis/pull/3121#discussion_r421536142
##########
File path: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessage.java
##########
@@ -91,7 +91,7 @@
entry.getKey().equals("priority")) {
// Ignore
} else if (entry.getKey().equals("userID")) {
- jmsMessage.put("JMSMessageID", entry.getValue().toString());
+ jmsMessage.put(" JMSMessageID", entry.getValue().toString());
Review comment:
fixing now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev commented on a change in pull request #3121: ARTEMIS-2749 - Broadcast Group Control Improvements
Posted by GitBox <gi...@apache.org>.
brusdev commented on a change in pull request #3121:
URL: https://github.com/apache/activemq-artemis/pull/3121#discussion_r421529546
##########
File path: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessage.java
##########
@@ -91,7 +91,7 @@
entry.getKey().equals("priority")) {
// Ignore
} else if (entry.getKey().equals("userID")) {
- jmsMessage.put("JMSMessageID", entry.getValue().toString());
+ jmsMessage.put(" JMSMessageID", entry.getValue().toString());
Review comment:
It looks like a typo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org