You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/20 03:06:05 UTC

[GitHub] [apisix] imjoey commented on a change in pull request #2469: feat(prometheus): Add consumer metric data support

imjoey commented on a change in pull request #2469:
URL: https://github.com/apache/apisix/pull/2469#discussion_r508180973



##########
File path: apisix/plugins/prometheus/exporter.lua
##########
@@ -95,23 +95,23 @@ function _M.init()
             "Etcd modify index for APISIX keys",
             {"key"})
 
-    -- per service
+    -- per service and consumer
     metrics.status = prometheus:counter("http_status",
             "HTTP status codes per service in APISIX",
-            {"code", "route", "service", "node"})
+            {"code", "route", "service", "consumer", "node"})

Review comment:
       @liuxiran more detailed comment is added, thanks for your suggestions.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org