You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/02/11 16:16:01 UTC
[kudu-CR] [client] Mark GetUnscaledDecimal as const
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12432
Change subject: [client] Mark GetUnscaledDecimal as const
......................................................................
[client] Mark GetUnscaledDecimal as const
The KuduPartialRow::GetUnscaledDecimal functions
are missing the const keyword.
Change-Id: I91d1d21a76179ff511eb5723958dcfb3d5eae0a2
---
M src/kudu/common/partial_row.cc
M src/kudu/common/partial_row.h
2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/12432/1
--
To view, visit http://gerrit.cloudera.org:8080/12432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I91d1d21a76179ff511eb5723958dcfb3d5eae0a2
Gerrit-Change-Number: 12432
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [client] Mark GetUnscaledDecimal as const
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12432 )
Change subject: [client] Mark GetUnscaledDecimal as const
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d1d21a76179ff511eb5723958dcfb3d5eae0a2
Gerrit-Change-Number: 12432
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 11 Feb 2019 17:07:44 +0000
Gerrit-HasComments: No
[kudu-CR] [client] Mark GetUnscaledDecimal as const
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12432 )
Change subject: [client] Mark GetUnscaledDecimal as const
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d1d21a76179ff511eb5723958dcfb3d5eae0a2
Gerrit-Change-Number: 12432
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 11 Feb 2019 16:56:29 +0000
Gerrit-HasComments: No
[kudu-CR] [client] Mark GetUnscaledDecimal as const
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12432 )
Change subject: [client] Mark GetUnscaledDecimal as const
......................................................................
[client] Mark GetUnscaledDecimal as const
The KuduPartialRow::GetUnscaledDecimal functions
are missing the const keyword.
Change-Id: I91d1d21a76179ff511eb5723958dcfb3d5eae0a2
Reviewed-on: http://gerrit.cloudera.org:8080/12432
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/common/partial_row.cc
M src/kudu/common/partial_row.h
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Kudu Jenkins: Verified
Todd Lipcon: Looks good to me, approved
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I91d1d21a76179ff511eb5723958dcfb3d5eae0a2
Gerrit-Change-Number: 12432
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>