[GitHub] [pulsar] wolfstudy commented on issue #4746: [go function] fix: go function should parse conf content first

[GitBox <gi...@apache.org>]

wolfstudy commented on issue #4746: [go function] fix: go function should parse conf content first
URL: https://github.com/apache/pulsar/pull/4746#issuecomment-512637739
 
 
   Thanks @freeznet work here. Indeed, the check logic before is not strict enough, when `confFilePath != ""` we should further check if this path is a valid path, as follows:
   
   ```
   func FileExists(datadir string) bool {
   	_, err := os.Stat(datadir)
   	if err != nil && os.IsNotExist(err) {
   		return false
   	}
   
   	return true
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services