You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/02/28 21:58:38 UTC
[GitHub] [druid] jasonk000 commented on a change in pull request #12096: perf: improve RemoteTaskRunner task assignment loop performance
jasonk000 commented on a change in pull request #12096:
URL: https://github.com/apache/druid/pull/12096#discussion_r816281705
##########
File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/ZkWorker.java
##########
@@ -102,19 +136,29 @@ public Worker getWorker()
@JsonProperty("currCapacityUsed")
public int getCurrCapacityUsed()
+ {
+ return getCurrCapacityUsed(getRunningTasks());
+ }
+
+ static int getCurrCapacityUsed(Map<String, TaskAnnouncement> tasks)
{
int currCapacity = 0;
- for (TaskAnnouncement taskAnnouncement : getRunningTasks().values()) {
+ for (TaskAnnouncement taskAnnouncement : tasks.values()) {
currCapacity += taskAnnouncement.getTaskResource().getRequiredCapacity();
}
return currCapacity;
}
@JsonProperty("availabilityGroups")
public Set<String> getAvailabilityGroups()
+ {
+ return getAvailabilityGroups(getRunningTasks());
+ }
+
+ static Set<String> getAvailabilityGroups(Map<String, TaskAnnouncement> tasks)
Review comment:
fixed in https://github.com/apache/druid/pull/12096/commits/b9b13195c4c640ceaf73d18f5fea355bf86247fd
##########
File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/ZkWorker.java
##########
@@ -102,19 +136,29 @@ public Worker getWorker()
@JsonProperty("currCapacityUsed")
public int getCurrCapacityUsed()
+ {
+ return getCurrCapacityUsed(getRunningTasks());
+ }
+
+ static int getCurrCapacityUsed(Map<String, TaskAnnouncement> tasks)
Review comment:
fixed in https://github.com/apache/druid/pull/12096/commits/b9b13195c4c640ceaf73d18f5fea355bf86247fd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org