[GitHub] [spark] MaxGekk commented on a diff in pull request #40593: [WIP][SQL] Define typed literal constructors as keywords

["MaxGekk (via GitHub)" <gi...@apache.org>]

MaxGekk commented on code in PR #40593:
URL: https://github.com/apache/spark/pull/40593#discussion_r1152878072


##########
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -928,11 +928,19 @@ primaryExpression
         (FILTER LEFT_PAREN WHERE where=booleanExpression RIGHT_PAREN)? ( OVER windowSpec)?     #percentile
     ;
 
+valueType
+    : DATE
+    | TIMESTAMP | TIMESTAMP_LTZ | TIMESTAMP_NTZ
+    | INTERVAL
+    | HEX

Review Comment:
   Maybe, `HEX_BINARY`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org