[GitHub] [spark] dbtsai commented on a change in pull request #27824: [SPARK-31064] [SQL] New Parquet Predicate Filter APIs with multi-part Identifier Support

[GitBox <gi...@apache.org>]

dbtsai commented on a change in pull request #27824: [SPARK-31064] [SQL] New Parquet Predicate Filter APIs with multi-part Identifier Support
URL: https://github.com/apache/spark/pull/27824#discussion_r388708917
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
 ##########
 @@ -126,264 +126,270 @@ class ParquetFilters(
     Binary.fromConstantByteArray(fixedLengthBytes, 0, numBytes)
   }
 
-  private val makeEq: PartialFunction[ParquetSchemaType, (String, Any) => FilterPredicate] = {
+  private val makeEq
+  : PartialFunction[ParquetSchemaType, (Array[String], Any) => FilterPredicate] = {
 
 Review comment:
   Adding two space here?
   
   Should I move `:` to previous line?
   
   ```scala
     private val makeEq:
       PartialFunction[ParquetSchemaType, (Array[String], Any) => FilterPredicate] = {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org