You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2016/02/16 21:00:46 UTC
Review Request 43618: Added examples for documentation on master/slave
state.json.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43618/
-----------------------------------------------------------
Review request for mesos, Michael Park and Vinod Kone.
Bugs: MESOS-3568
https://issues.apache.org/jira/browse/MESOS-3568
Repository: mesos
Description
-------
We are working on a more standardized way of representing (and thus
more easily documenting) our internal JSON objects. Until we have
this, there is no point in trying to exhaustively document the
state.json (or any other JSON) endpoints. Including an example and
noting that it is not exhaustive is better than it was before though.
Diffs
-----
src/master/http.cpp f92212bf69f9db51d729347fb553e74e28e105fd
src/slave/http.cpp 523e8dc5d5cc435aaba463a17520237a6c7b192c
src/slave/monitor.cpp 5c1dd354595e67e5eb8888603c5d49850f84b84b
Diff: https://reviews.apache.org/r/43618/diff/
Testing
-------
Thanks,
Kevin Klues
Re: Review Request 43618: Added examples for documentation on
master/slave state.json.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43618/#review119389
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 16, 2016, 9:59 p.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43618/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2016, 9:59 p.m.)
>
>
> Review request for mesos, Michael Park and Vinod Kone.
>
>
> Bugs: MESOS-3568
> https://issues.apache.org/jira/browse/MESOS-3568
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We are working on a more standardized way of representing (and thus
> more easily documenting) our internal JSON objects. Until we have
> this, there is no point in trying to exhaustively document the
> state.json (or any other JSON) endpoints. Including an example and
> noting that it is not exhaustive is better than it was before though.
>
>
> Diffs
> -----
>
> src/master/http.cpp f92212bf69f9db51d729347fb553e74e28e105fd
> src/slave/http.cpp 523e8dc5d5cc435aaba463a17520237a6c7b192c
>
> Diff: https://reviews.apache.org/r/43618/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 43618: Added examples for documentation on
master/slave state.json.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43618/
-----------------------------------------------------------
(Updated Feb. 16, 2016, 9:59 p.m.)
Review request for mesos, Michael Park and Vinod Kone.
Changes
-------
Add newline between "Example:" and the JSON to generate proper markdown. Also, make the word NOTE in bold, not italics.
Bugs: MESOS-3568
https://issues.apache.org/jira/browse/MESOS-3568
Repository: mesos
Description
-------
We are working on a more standardized way of representing (and thus
more easily documenting) our internal JSON objects. Until we have
this, there is no point in trying to exhaustively document the
state.json (or any other JSON) endpoints. Including an example and
noting that it is not exhaustive is better than it was before though.
Diffs (updated)
-----
src/master/http.cpp f92212bf69f9db51d729347fb553e74e28e105fd
src/slave/http.cpp 523e8dc5d5cc435aaba463a17520237a6c7b192c
Diff: https://reviews.apache.org/r/43618/diff/
Testing
-------
Thanks,
Kevin Klues