You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by subrotosanyal <gi...@git.apache.org> on 2016/06/03 11:04:49 UTC
[GitHub] spark pull request #13497: Added a new State (FINISHED_UNKNOWN) for the list...
GitHub user subrotosanyal opened a pull request:
https://github.com/apache/spark/pull/13497
Added a new State (FINISHED_UNKNOWN) for the listeners of SparkLauncher
## What changes were proposed in this pull request?
This situation can happen when the LauncherConnection gets an exception while reading through the socket and terminating silently without notifying making the client/listener think that the job is still in previous state.
The fix force sends a notification to client that the job finished with unknown status and let client handle it accordingly.
## How was this patch tested?
Added a unit test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/subrotosanyal/spark SPARK-15652-handle-spark-submit-jvm-crash
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13497.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13497
----
commit 3d9b78f4656a2e2329ee014199e7cc4fe42ac375
Author: Subroto Sanyal <ss...@datameer.com>
Date: 2016-06-03T10:58:51Z
SPARK-15652 Added a new State (FINISHED_UNKNOW) which will be used if the LauncherConnection gets an exception while reading through the socket. The failure of reading through the socket could be crash of the Spark Submit JVM. The fix force sends a notification to client that the job finished with unknown status.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13497
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: SPARK-15652 Added a new State (FINISHED_UNKNOWN) for the...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13497
**[Test build #59960 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59960/consoleFull)** for PR 13497 at commit [`3d9b78f`](https://github.com/apache/spark/commit/3d9b78f4656a2e2329ee014199e7cc4fe42ac375).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13497: SPARK-15652 Added a new State (FINISHED_UNKNOWN) ...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13497#discussion_r65773920
--- Diff: launcher/src/main/java/org/apache/spark/launcher/SparkAppHandle.java ---
@@ -43,6 +43,8 @@
RUNNING(false),
/** The application finished with a successful status. */
FINISHED(true),
+ /** The Spark Submit JVM got killed with a unknown status. */
+ FINISHED_UNKNOWN(true),
--- End diff --
This should be declared after existing constants, since declaring it here will change the `ordinal()` value of existing constants, which is a binary compatibility issue. A better name would be good also; maybe "LOST" or "DISCONNECTED"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by subrotosanyal <gi...@git.apache.org>.
Github user subrotosanyal commented on the issue:
https://github.com/apache/spark/pull/13497
hi @vanzin
Thanks for your comments. Could you please have look to the changes?
The build is green.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13497
**[Test build #60049 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60049/consoleFull)** for PR 13497 at commit [`1ba8c48`](https://github.com/apache/spark/commit/1ba8c4894ed12db6eb26feeb0544a1fa9c5b9b6d).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13497
**[Test build #60048 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60048/consoleFull)** for PR 13497 at commit [`c27e2c3`](https://github.com/apache/spark/commit/c27e2c378ddb74a580c12433cfc33bf2cc16f8e2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: SPARK-15652 Added a new State (FINISHED_UNKNOWN) for the...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/13497
@subrotosanyal you also need to change the title to follow the usual convention. thx
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: SPARK-15652 Added a new State (FINISHED_UNKNOWN) for the...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13497
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: SPARK-15652 Added a new State (FINISHED_UNKNOWN) for the...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13497
**[Test build #60034 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60034/consoleFull)** for PR 13497 at commit [`52118e6`](https://github.com/apache/spark/commit/52118e63cded342565c7c477c7ec7e011fc63633).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: SPARK-15652 Added a new State (FINISHED_UNKNOWN) for the...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13497
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13497: [SPARK-15652] [launcher] Added a new State (LOST)...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13497#discussion_r65927782
--- Diff: launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java ---
@@ -337,6 +337,10 @@ public void close() throws IOException {
}
super.close();
if (handle != null) {
+ if (!handle.getState().isFinal()) {
+ LOG.log(Level.WARNING, "Lost connection to launch server.");
--- End diff --
minor: this is running in the server, so you lost the connection to the Spark application.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13497
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60046/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13497
**[Test build #60059 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60059/consoleFull)** for PR 13497 at commit [`72ea2ca`](https://github.com/apache/spark/commit/72ea2ca05a55d0cab5b8cd694df6f95fb9a0c76a).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (FINISHED_UNK...
Posted by subrotosanyal <gi...@git.apache.org>.
Github user subrotosanyal commented on the issue:
https://github.com/apache/spark/pull/13497
hi @vanzin
Worked on the comments. Request code review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: SPARK-15652 Added a new State (FINISHED_UNKNOWN) for the...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13497
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59960/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13497: SPARK-15652 Added a new State (FINISHED_UNKNOWN) ...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13497#discussion_r65774304
--- Diff: launcher/src/test/java/org/apache/spark/launcher/LauncherServerSuite.java ---
@@ -17,19 +17,42 @@
package org.apache.spark.launcher;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNotSame;
+import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertSame;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
+
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
import java.io.Closeable;
+import java.io.EOFException;
import java.io.IOException;
+import java.io.InputStream;
+import java.io.ObjectOutputStream;
import java.net.InetAddress;
import java.net.Socket;
+import java.util.List;
+import java.util.concurrent.ArrayBlockingQueue;
import java.util.concurrent.BlockingQueue;
import java.util.concurrent.LinkedBlockingQueue;
import java.util.concurrent.Semaphore;
import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+import org.apache.spark.launcher.LauncherProtocol.Hello;
+import org.apache.spark.launcher.LauncherProtocol.Message;
+import org.apache.spark.launcher.LauncherProtocol.SetAppId;
+import org.apache.spark.launcher.LauncherProtocol.SetState;
+import org.apache.spark.launcher.LauncherProtocol.Stop;
+import org.apache.spark.launcher.SparkAppHandle.State;
import org.junit.Test;
-import static org.junit.Assert.*;
+import org.mockito.Mockito;
+
+import com.google.common.collect.Lists;
--- End diff --
This module doesn't depend on Guava, so this would probably cause a failure (at least when using maven). With Java 7 it's pretty easy to avoid these particular Guava classes, though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/13497
LGTM. Merging to master / 2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13497
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60059/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13497
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60048/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13497
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: Added a new State (FINISHED_UNKNOWN) for the listeners o...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13497
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13497
**[Test build #60059 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60059/consoleFull)** for PR 13497 at commit [`72ea2ca`](https://github.com/apache/spark/commit/72ea2ca05a55d0cab5b8cd694df6f95fb9a0c76a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13497: SPARK-15652 Added a new State (FINISHED_UNKNOWN) ...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13497#discussion_r65774423
--- Diff: launcher/src/test/java/org/apache/spark/launcher/LauncherServerSuite.java ---
@@ -152,6 +175,102 @@ public void testTimeout() throws Exception {
}
}
+ @Test
+ public void testSparkSubmitVmShutsDown() throws Exception {
+ LauncherServer launchServer = (LauncherServer)Mockito.mock(LauncherServer.class);
--- End diff --
style nits:
- code is cleaner if you just static import `Mockito.*`
- space after casts: `(LauncherServer) mock(...)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13497: SPARK-15652 Added a new State (FINISHED_UNKNOWN) ...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13497#discussion_r65773746
--- Diff: launcher/src/main/java/org/apache/spark/launcher/LauncherConnection.java ---
@@ -107,4 +106,17 @@ public void close() throws IOException {
}
}
+ private void close(Exception exp) throws IOException {
+ if (!closed) {
+ synchronized (this) {
+ if (!closed) {
+ handle(new SetState(State.FINISHED_UNKNOWN));
--- End diff --
Hmm, this looks out of place. I think a better place for this is the `ServerConnection` class (in `LauncherServer.java`). That's the class that understands this message. Then your patch is also much simpler since you don't need this second close method, it turns into a single line in `ServerConnection.close` (and maybe a log message).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13497
**[Test build #60047 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60047/consoleFull)** for PR 13497 at commit [`0472e25`](https://github.com/apache/spark/commit/0472e2549a24fffe31c766a27765bf6c1c6895df).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: SPARK-15652 Added a new State (FINISHED_UNKNOWN) for the...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/13497
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13497
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60047/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13497
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13497
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60040/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: SPARK-15652 Added a new State (FINISHED_UNKNOWN) for the...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13497
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60034/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13497
**[Test build #60046 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60046/consoleFull)** for PR 13497 at commit [`da229b0`](https://github.com/apache/spark/commit/da229b0cce0d69afe7f30220ed31329f46d65356).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13497: SPARK-15652 Added a new State (FINISHED_UNKNOWN) ...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13497#discussion_r65773416
--- Diff: launcher/src/main/java/org/apache/spark/launcher/LauncherConnection.java ---
@@ -107,4 +106,17 @@ public void close() throws IOException {
}
}
+ private void close(Exception exp) throws IOException {
+ if (!closed) {
--- End diff --
Spark uses 2 spaces for indentation. Your code later is also indented wrongly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13497: SPARK-15652 Added a new State (FINISHED_UNKNOWN) ...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13497#discussion_r65774014
--- Diff: launcher/src/test/java/org/apache/spark/launcher/LauncherServerSuite.java ---
@@ -17,19 +17,42 @@
package org.apache.spark.launcher;
+import static org.junit.Assert.assertEquals;
--- End diff --
This might be your IDE, but please don't explode (or re-order) existing imports like this. It's unnecessary noise and actually against Spark's code conventions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13497
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60049/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13497
**[Test build #60040 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60040/consoleFull)** for PR 13497 at commit [`f157c73`](https://github.com/apache/spark/commit/f157c733ad75ebc5235b2a7cb1d979f0429be943).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: SPARK-15652 Added a new State (FINISHED_UNKNOWN) for the...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13497
**[Test build #60034 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60034/consoleFull)** for PR 13497 at commit [`52118e6`](https://github.com/apache/spark/commit/52118e63cded342565c7c477c7ec7e011fc63633).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13497
**[Test build #60046 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60046/consoleFull)** for PR 13497 at commit [`da229b0`](https://github.com/apache/spark/commit/da229b0cce0d69afe7f30220ed31329f46d65356).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13497: SPARK-15652 Added a new State (FINISHED_UNKNOWN) ...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13497#discussion_r65775002
--- Diff: launcher/src/test/java/org/apache/spark/launcher/LauncherServerSuite.java ---
@@ -152,6 +175,102 @@ public void testTimeout() throws Exception {
}
}
+ @Test
+ public void testSparkSubmitVmShutsDown() throws Exception {
--- End diff --
This test looks very complicated. Why not:
- create a server and a client that connects to it
- initiate the connection (send "Hello")
- close the client socket
- verify the server socket fires the expected event
This would be very similar to `testCommunication` above until about L112. After that you just close the client socket and wait for the event on the handle.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13497
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60058/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13497
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: SPARK-15652 Added a new State (FINISHED_UNKNOWN) for the...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13497
**[Test build #59960 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59960/consoleFull)** for PR 13497 at commit [`3d9b78f`](https://github.com/apache/spark/commit/3d9b78f4656a2e2329ee014199e7cc4fe42ac375).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13497
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13497
**[Test build #60048 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60048/consoleFull)** for PR 13497 at commit [`c27e2c3`](https://github.com/apache/spark/commit/c27e2c378ddb74a580c12433cfc33bf2cc16f8e2).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13497
**[Test build #60058 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60058/consoleFull)** for PR 13497 at commit [`3edb36a`](https://github.com/apache/spark/commit/3edb36a363ef994c2866d224921f1545e825f7d9).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13497: [SPARK-15652] [launcher] Added a new State (LOST)...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13497#discussion_r65928683
--- Diff: launcher/src/test/java/org/apache/spark/launcher/LauncherServerSuite.java ---
@@ -152,6 +157,69 @@ public void testTimeout() throws Exception {
}
}
+ @Test
+ public void testSparkSubmitVmShutsDown() throws Exception {
+ ChildProcAppHandle handle = LauncherServer.newAppHandle();
+ TestClient client = null;
+ final List<SparkAppHandle.State> expectedStateList = Arrays.asList(SparkAppHandle.State.CONNECTED, SparkAppHandle.State.LOST);
+ final List<SparkAppHandle.State> realStateList = new ArrayList<SparkAppHandle.State>(2);
+ final AtomicBoolean jobFinished = new AtomicBoolean(false);
+ final BlockingQueue<SparkAppHandle.State> stateQueue = new LinkedBlockingQueue<SparkAppHandle.State>(10);
+ final Semaphore semaphore = new Semaphore(0);
+ try {
+ Socket s = new Socket(InetAddress.getLoopbackAddress(),
+ LauncherServer.getServerInstance().getPort());
+ handle.addListener(new SparkAppHandle.Listener() {
+ public void stateChanged(SparkAppHandle handle) {
+ stateQueue.offer(handle.getState());
+ semaphore.release();
+ }
+ public void infoChanged(SparkAppHandle handle) {
+ semaphore.release();
+ }
+ });
+ client = new TestClient(s);
+ client.send(new Hello(handle.getSecret(), "1.4.0"));
+ assertTrue(semaphore.tryAcquire(30, TimeUnit.SECONDS));
+ // Make sure the server matched the client to the handle.
+ assertNotNull(handle.getConnection());
+ Thread sparkLauncherClient = new Thread() {
+ public void run() {
+ while (!jobFinished.get()) {
+ SparkAppHandle.State state = SparkAppHandle.State.UNKNOWN;
+ try {
+ state = (SparkAppHandle.State)stateQueue.take();
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ throw new RuntimeException(e);
+ }
+ switch (state) {
+ case CONNECTED:
+ realStateList.add(state);
+ break;
+ case LOST:
+ jobFinished.set(true);
+ realStateList.add(state);
+ break;
+ default:
+ throw new RuntimeException(String.format("Unexpected state. The should have been one of the %s.", expectedStateList));
+ }
+ }
+ }
+ };
+ sparkLauncherClient.start();
+ close(client);
+ sparkLauncherClient.join(10000L);
--- End diff --
Do you need this separate thread? Seems to me like all you need is:
```
close(client);
assertTrue(semaphore.tryAcquire(30, TimeUnit.SECONDS));
assertEquals(SparkAppHandle.State.LOST, handle.getState());
```
That gets rid of a bunch of code in your tests and tests just the code you're interested in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13497
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13497: [SPARK-15652] [launcher] Added a new State (LOST)...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13497#discussion_r65927836
--- Diff: launcher/src/main/java/org/apache/spark/launcher/SparkAppHandle.java ---
@@ -46,7 +46,9 @@
/** The application finished with a failed status. */
FAILED(true),
/** The application was killed. */
- KILLED(true);
+ KILLED(true),
+ /** The Spark Submit JVM got killed with a unknown status. */
--- End diff --
s/got killed/exited
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13497
**[Test build #60049 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60049/consoleFull)** for PR 13497 at commit [`1ba8c48`](https://github.com/apache/spark/commit/1ba8c4894ed12db6eb26feeb0544a1fa9c5b9b6d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13497
**[Test build #60047 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60047/consoleFull)** for PR 13497 at commit [`0472e25`](https://github.com/apache/spark/commit/0472e2549a24fffe31c766a27765bf6c1c6895df).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13497
**[Test build #60058 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60058/consoleFull)** for PR 13497 at commit [`3edb36a`](https://github.com/apache/spark/commit/3edb36a363ef994c2866d224921f1545e825f7d9).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (FINISHED_UNK...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13497
**[Test build #60040 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60040/consoleFull)** for PR 13497 at commit [`f157c73`](https://github.com/apache/spark/commit/f157c733ad75ebc5235b2a7cb1d979f0429be943).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13497: [SPARK-15652] [launcher] Added a new State (LOST) for th...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13497
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13497: [SPARK-15652] [launcher] Added a new State (LOST)...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13497
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org