Re: Review Request 14274: PIG-2672 Optimize the use of DistributedCache

[Rohini Palaniswamy <ro...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14274/#review33391
-----------------------------------------------------------



trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/JobControlCompiler.java
<https://reviews.apache.org/r/14274/#comment62849>

    Not using job staging directory is ok as the setting differ in 1.x (it is a jobtracker setting) and 2.x and within 2.x itself ( it is yarn.app.mapreduce.am.staging-dir for MR and tez.staging-dir for tez). But can we have another setting instead of PIG_TEMP_DIR? Would really like to set it to /user if we enable it in our grids. 
    
    May be
    conf.get(PIG_CACHE_DIR, conf.get(PIG_TEMP_DIR, "/tmp")



trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/JobControlCompiler.java
<https://reviews.apache.org/r/14274/#comment62851>

    If .pigcache did not already exist, then it will be created with permissions only for the current user and you will not be able to create directories for other users under .pigcache. You should do currentUser + "/.pigCache" to avoid that. Also make a setPermissions call seperately after mkdirs. If someone had it precreated it with 777, then that would be a problem.



trunk/src/org/apache/pig/impl/io/FileLocalizer.java
<https://reviews.apache.org/r/14274/#comment62848>

    Can you rename it to OWNER_ONLY_PERMS before committing?


- Rohini Palaniswamy


On Jan. 31, 2014, 1:23 a.m., Aniket Mokashi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14274/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2014, 1:23 a.m.)
> 
> 
> Review request for pig, Cheolsoo Park, DanielWX DanielWX, Dmitriy Ryaboy, Julien Le Dem, and Rohini Palaniswamy.
> 
> 
> Bugs: PIG-2672
>     https://issues.apache.org/jira/browse/PIG-2672
> 
> 
> Repository: pig
> 
> 
> Description
> -------
> 
> added jar.cache.location option
> 
> 
> Diffs
> -----
> 
>   trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java 1563022 
>   trunk/src/org/apache/pig/PigConfiguration.java 1563022 
>   trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/JobControlCompiler.java 1563022 
>   trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/MapReduceLauncher.java 1563022 
>   trunk/src/org/apache/pig/impl/io/FileLocalizer.java 1563022 
>   trunk/test/org/apache/pig/test/TestMultiQueryLocal.java 1563022 
>   trunk/test/org/apache/pig/test/TestPigServer.java 1563022 
> 
> Diff: https://reviews.apache.org/r/14274/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aniket Mokashi
> 
>