[GitHub] [beam] johnjcasey commented on a diff in pull request #17380: [BEAM-14314][BEAM-9532] Add last_updated field in filesystem.FileMetaData

[GitBox <gi...@apache.org>]

johnjcasey commented on code in PR #17380:
URL: https://github.com/apache/beam/pull/17380#discussion_r854213018


##########
sdks/python/apache_beam/io/filesystem.py:
##########
@@ -421,27 +421,44 @@ def __exit__(self, exception_type, exception_value, traceback):
 
 
 class FileMetadata(object):
-  """Metadata about a file path that is the output of FileSystem.match."""
-  def __init__(self, path, size_in_bytes):
+  """Metadata about a file path that is the output of FileSystem.match.
+
+  Fields:
+    path: [Required] file path.
+    size_in_bytes: [Required] file size in bytes.
+    last_updated_in_seconds: [Optional] last modified timestamp of the file, or
+    valued 0.0 if not specified.

Review Comment:
   Lets ask in the next catch up which direction is better



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org