You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by "IsmoLeszczynski (via GitHub)" <gi...@apache.org> on 2024/04/12 08:38:47 UTC
[PR] fix(plc4j/ads): Fixed List serialization passing invalid datatype
IsmoLeszczynski opened a new pull request, #1517:
URL: https://github.com/apache/plc4x/pull/1517
Fix for: #1509
The List serialization for ADS passed the main List type to each child element when serializing them instead of determining the correct type for the children. This fix modifies the List iteration to determine the simple type from the List type, which is the actual type for each child element.
Regarding the `arrayInfo.subList()`, I'm not familiar enough to say if that should also be determined from the child type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(plc4j/ads): Fixed List serialization passing invalid datatype
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on PR #1517:
URL: https://github.com/apache/plc4x/pull/1517#issuecomment-2051541475
Having a deeper look ... I am not sure this is a universal fix for the problem. In 90% of the entries in the dataTypeTable the simpleDataTypeName is "". I think it's only used in cased of refereces, Arrays and some of the system types. I would assume you're reading one of these system types, so I guess your fix would make that work, but break the regular DTOs.
I'll have a deeper look into to the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(plc4j/ads): Fixed List serialization passing invalid datatype
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on PR #1517:
URL: https://github.com/apache/plc4x/pull/1517#issuecomment-2051562702
Zooming a bit out of the code ... you are absolutely correct ... this part of the code handles the array serialization. And in this case the datatype will always be an "Array of LALALA" and in that case simple type will always contain "LALALA" ...
Thanks for spotting this ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(plc4j/ads): Fixed List serialization passing invalid datatype
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz merged PR #1517:
URL: https://github.com/apache/plc4x/pull/1517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org