[GitHub] [spark] LuciferYang commented on a diff in pull request #41293: [SPARK-43769][CONNECT] Implement 'levenshtein(str1, str2[, threshold])' functions

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #41293:
URL: https://github.com/apache/spark/pull/41293#discussion_r1204321957


##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/ClientE2ETestSuite.scala:
##########
@@ -801,6 +801,19 @@ class ClientE2ETestSuite extends RemoteSparkSession with SQLHelper {
     assert(plan.sameSemantics(otherPlan))
   }
 
+  test("levenshtein") {

Review Comment:
   The test is ok, but it may not be necessary to add this e2e test, as other functions don't have e2e tests now. Add new test to PlanGenerationTestSuite is enough
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org