You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "justinpark (via GitHub)" <gi...@apache.org> on 2023/05/19 18:58:42 UTC
[GitHub] [superset] justinpark opened a new pull request, #24142: fix(sqllab): Table options rendering regression
justinpark opened a new pull request, #24142:
URL: https://github.com/apache/superset/pull/24142
### SUMMARY
There's a rendering perf regression from #22084
When SelectAll feature introduced by [#22084
](https://github.com/apache/superset/pull/22084/files#diff-0cb43ca54c9f49fa7c2283133c0841b0c8fb7b464130038d7dba2543cca5b498L329), Select component became rendering options by jsx only. This makes the performance degraded for the large size options.
```
options | Select options. Will get better perf than jsx definition
-- | --
```
This commit recovers the way to use options prop as before (including SelectAll condition)
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After: (~100ms)
<img width="565" alt="Screenshot 2023-05-19 at 11 22 50 AM" src="https://github.com/apache/superset/assets/1392866/0d2d7974-e85e-48d0-bbe8-f02c41d2421c">
Before: (>5000ms)
<img width="756" alt="Screenshot 2023-05-19 at 11 18 14 AM" src="https://github.com/apache/superset/assets/1392866/594f793f-f8f9-4fb0-91a9-f9ebe5e7873b">
### TESTING INSTRUCTIONS
select a large size table option schema
click the table dropdown and then measure the delay
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a diff in pull request #24142: fix(sqllab): Table options rendering regression
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #24142:
URL: https://github.com/apache/superset/pull/24142#discussion_r1199342036
##########
superset-frontend/src/components/Select/Select.tsx:
##########
@@ -440,6 +441,11 @@ const Select = forwardRef(
onChange?.(newValues, newOptions);
};
+ const shouldUseChildrenOptions = useMemo(
+ () => !selectAllEnabled || hasCustomLabels(options),
Review Comment:
```suggestion
() => selectAllEnabled || hasCustomLabels(options),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24142: fix(sqllab): Table options rendering regression
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24142:
URL: https://github.com/apache/superset/pull/24142#issuecomment-1555271366
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24142?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24142](https://app.codecov.io/gh/apache/superset/pull/24142?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (586a31d) into [master](https://app.codecov.io/gh/apache/superset/commit/515986172f0954b01ad72d19cdb7b2ac0798f60f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5159861) will **decrease** coverage by `0.02%`.
> The diff coverage is `72.25%`.
> :exclamation: Current head 586a31d differs from pull request most recent head 2bba1f9. Consider uploading reports for the commit 2bba1f9 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24142 +/- ##
==========================================
- Coverage 68.28% 68.26% -0.02%
==========================================
Files 1952 1952
Lines 75432 75353 -79
Branches 8191 8207 +16
==========================================
- Hits 51505 51437 -68
+ Misses 21823 21810 -13
- Partials 2104 2106 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `54.69% <47.27%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...set-ui-core/src/ui-overrides/ExtensionsRegistry.ts](https://app.codecov.io/gh/apache/superset/pull/24142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdWktb3ZlcnJpZGVzL0V4dGVuc2lvbnNSZWdpc3RyeS50cw==) | `100.00% <ø> (ø)` | |
| [...end/src/features/databases/DatabaseModal/styles.ts](https://app.codecov.io/gh/apache/superset/pull/24142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2RhdGFiYXNlcy9EYXRhYmFzZU1vZGFsL3N0eWxlcy50cw==) | `77.66% <ø> (ø)` | |
| [superset-frontend/src/pages/DatabaseList/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL0RhdGFiYXNlTGlzdC9pbmRleC50c3g=) | `66.03% <0.00%> (ø)` | |
| [superset/commands/importers/v1/assets.py](https://app.codecov.io/gh/apache/superset/pull/24142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL2Fzc2V0cy5weQ==) | `88.09% <0.00%> (+2.04%)` | :arrow_up: |
| [superset/config.py](https://app.codecov.io/gh/apache/superset/pull/24142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.97% <ø> (-0.05%)` | :arrow_down: |
| [superset/datasets/commands/importers/v1/utils.py](https://app.codecov.io/gh/apache/superset/pull/24142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `79.41% <0.00%> (+0.77%)` | :arrow_up: |
| [superset/db\_engine\_specs/databricks.py](https://app.codecov.io/gh/apache/superset/pull/24142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RhdGFicmlja3MucHk=) | `70.92% <0.00%> (+0.49%)` | :arrow_up: |
| [superset/db\_engine\_specs/snowflake.py](https://app.codecov.io/gh/apache/superset/pull/24142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Nub3dmbGFrZS5weQ==) | `67.64% <0.00%> (+0.39%)` | :arrow_up: |
| [superset/migrations/env.py](https://app.codecov.io/gh/apache/superset/pull/24142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9lbnYucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/models/helpers.py](https://app.codecov.io/gh/apache/superset/pull/24142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `69.90% <0.00%> (+0.07%)` | :arrow_up: |
| ... and [74 more](https://app.codecov.io/gh/apache/superset/pull/24142?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24142/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark merged pull request #24142: fix(sqllab): Table options rendering regression
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark merged PR #24142:
URL: https://github.com/apache/superset/pull/24142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org