You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/10 13:42:13 UTC

[GitHub] [airflow] ashb opened a new issue #16371: Make `XCom.get_one()` + `get_many()` accept run_id

ashb opened a new issue #16371:
URL: https://github.com/apache/airflow/issues/16371


   XCom.get_* methods current accept an execution_date, and need to accept a run_id now.
   
   We should add back-compat shims so that any python_operators that call these methods continue to work.
   
   There needs to remain a kwarg called `execution_date` for DAGs/third party code to call, but any uses in Airflow (TI.xcom_pull for instance) should be updated to pass run_id directly)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb commented on issue #16371: Make `XCom.get_one()` + `get_many()` accept run_id

Posted by GitBox <gi...@apache.org>.
ashb commented on issue #16371:
URL: https://github.com/apache/airflow/issues/16371#issuecomment-916424567


   Closed by https://github.com/apache/airflow/pull/18084


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] uranusjr commented on issue #16371: Make `XCom.get_one()` + `get_many()` accept run_id

Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #16371:
URL: https://github.com/apache/airflow/issues/16371#issuecomment-875367435


   Similar to how we plan to associate `TaskInstance` to `DagRun` via `run_id` (instead of implicitly via `execution_date`), would it make sense to also add a `run_id` column on XCom as well? That (plus backfilled values) would make this a lot easier; currently since XCom only has `dag_id` and `execution_date`, we need to do an SQL join to filter with `run_id`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb closed issue #16371: Make `XCom.get_one()` + `get_many()` accept run_id

Posted by GitBox <gi...@apache.org>.
ashb closed issue #16371:
URL: https://github.com/apache/airflow/issues/16371


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org