You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by ma...@apache.org on 2007/03/30 09:22:01 UTC
svn commit: r523974 -
/incubator/openejb/trunk/openejb3/container/openejb-core/src/test/java/org/apache/openejb/core/mdb/MdbInvoker.java
Author: manugeorge
Date: Fri Mar 30 00:22:00 2007
New Revision: 523974
URL: http://svn.apache.org/viewvc?view=rev&rev=523974
Log:
changing the MdbInvoker code to open and then close a connection each time it needs one in a try/finally block.
Modified:
incubator/openejb/trunk/openejb3/container/openejb-core/src/test/java/org/apache/openejb/core/mdb/MdbInvoker.java
Modified: incubator/openejb/trunk/openejb3/container/openejb-core/src/test/java/org/apache/openejb/core/mdb/MdbInvoker.java
URL: http://svn.apache.org/viewvc/incubator/openejb/trunk/openejb3/container/openejb-core/src/test/java/org/apache/openejb/core/mdb/MdbInvoker.java?view=diff&rev=523974&r1=523973&r2=523974
==============================================================================
--- incubator/openejb/trunk/openejb3/container/openejb-core/src/test/java/org/apache/openejb/core/mdb/MdbInvoker.java (original)
+++ incubator/openejb/trunk/openejb3/container/openejb-core/src/test/java/org/apache/openejb/core/mdb/MdbInvoker.java Fri Mar 30 00:22:00 2007
@@ -36,14 +36,11 @@
private final Object target;
private Connection connection;
private Session session;
+ private ConnectionFactory connectionFactory;
public MdbInvoker(ConnectionFactory connectionFactory, Object target) throws JMSException {
this.target = target;
- connection = connectionFactory.createConnection();
- connection.start();
-
- session = connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
-
+ this.connectionFactory = connectionFactory;
for (Method method : target.getClass().getMethods()) {
String signature = MdbUtil.getSignature(method);
signatures.put(signature, method);
@@ -57,7 +54,10 @@
connection = null;
}
- private synchronized Session getSession() {
+ private synchronized Session getSession() throws JMSException {
+ connection = connectionFactory.createConnection();
+ connection.start();
+ session = connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
return session;
}
@@ -115,7 +115,8 @@
} catch (Exception e) {
e.printStackTrace();
} finally {
- MdbUtil.close(producer);
+ MdbUtil.close(producer);
+ destroy();
}
} catch (Throwable e) {
e.printStackTrace();