You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/07 08:31:50 UTC
[GitHub] [airflow] huage1994 opened a new pull request #19449: fix bug of SparkSql Operator log going to infinite loop.
huage1994 opened a new pull request #19449:
URL: https://github.com/apache/airflow/pull/19449
The log of SparkSql Operator will go to infinite loop, forever printing `INFO - b''`.
The reason is at line 185 in SparkSql.py :
`subprocess.Popen(spark_sql_cmd, stdout=subprocess.PIPE, stderr=subprocess.STDOUT, **kwargs)`
It should pass `universal_newlines=True` into this function, as what spark_submit.py do.
The default values of this function are: universal_newlines=False,meaning input/output is accepted as bytes, not Unicode strings plus the universal newlines mode handling.
[As is discussed in stackoverflow](https://stackoverflow.com/questions/38181494/what-is-the-difference-between-using-universal-newlines-true-with-bufsize-1-an):
> If universal_newlines=False then `for line in iter(self._sp.stdout)` iterates over b'\n'-separated lines. If the process uses non-ascii encoding e.g., UTF-16 for its output then even if os.linesep == '\n' on your system; you may get a wrong result. If you want to consume text lines, use the text mode: pass universal_newlines=True or use io.TextIOWrapper(process.stdout) explicitly.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #19449: fix bug of SparkSql Operator log going to infinite loop.
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #19449:
URL: https://github.com/apache/airflow/pull/19449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] huage1994 commented on pull request #19449: fix bug of SparkSql Operator log going to infinite loop.
Posted by GitBox <gi...@apache.org>.
huage1994 commented on pull request #19449:
URL: https://github.com/apache/airflow/pull/19449#issuecomment-963778748
> You need to fix static checks too.
Done. Thanks for your review! I didn't notice the static check in last CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] huage1994 commented on pull request #19449: fix bug of SparkSql Operator log going to infinite loop.
Posted by GitBox <gi...@apache.org>.
huage1994 commented on pull request #19449:
URL: https://github.com/apache/airflow/pull/19449#issuecomment-962769485
> I believe you will have to update tests for it to pass.
Thx! I have updated test_spark_sql.py and force-pushed the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19449: fix bug of SparkSql Operator log going to infinite loop.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19449:
URL: https://github.com/apache/airflow/pull/19449#issuecomment-966155860
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] huage1994 commented on pull request #19449: fix bug of SparkSql Operator log going to infinite loop.
Posted by GitBox <gi...@apache.org>.
huage1994 commented on pull request #19449:
URL: https://github.com/apache/airflow/pull/19449#issuecomment-976126448
Thanks for your review @uranusjr. Is there anything else I need to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19449: fix bug of SparkSql Operator log going to infinite loop.
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #19449:
URL: https://github.com/apache/airflow/pull/19449#issuecomment-978336622
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #19449: fix bug of SparkSql Operator log going to infinite loop.
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #19449:
URL: https://github.com/apache/airflow/pull/19449#issuecomment-976315281
At this stage we need more reviewers, so let’s just wait a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19449: fix bug of SparkSql Operator log going to infinite loop.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19449:
URL: https://github.com/apache/airflow/pull/19449#issuecomment-962598628
I believe you will have to update tests for it to pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19449: fix bug of SparkSql Operator log going to infinite loop.
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #19449:
URL: https://github.com/apache/airflow/pull/19449#issuecomment-962571231
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19449: fix bug of SparkSql Operator log going to infinite loop.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19449:
URL: https://github.com/apache/airflow/pull/19449#issuecomment-963427365
You need to fix static checks too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org