You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/28 17:23:51 UTC

[GitHub] [airflow] potiuk opened a new pull request #15577: Improves production image preparation scripts.

potiuk opened a new pull request #15577:
URL: https://github.com/apache/airflow/pull/15577


   This change improves the process of image preparation in DockerHub
   and manual version of it, in case the DockerHub automation does
   not work. It introduces the following changes:
   
   * The "nightly-master" builds were failing because they tried
     to prepare packages without the "dev" suffix (such packages
     are skipped now in case package with the same version has
     already been released). The "dev" suffix forces the packages
     to be build.
   
   * VERBOSE_COMMAND variable is removed to get more readable output
     of the script.
   
   * Image verification is now part of the process. The images are
     automatically tested after they are built and the scripts
     will not push the images if the images do not pass the
     verification.
   
   * Documentation is updated for both RC and final image preparation
     (Previous update did not update the RC image preparation)
   
   * Documentation is added to explain how to manually refresh the
     images in DockerHub in case the nightly builds are not running
     for a long time.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #15577: Improves production image preparation scripts.

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15577:
URL: https://github.com/apache/airflow/pull/15577#issuecomment-829892977


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #15577: Improves production image preparation scripts.

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15577:
URL: https://github.com/apache/airflow/pull/15577#issuecomment-828636640


   This should fix dockerhub buils @ashb @kaxil 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk merged pull request #15577: Improves production image preparation scripts.

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #15577:
URL: https://github.com/apache/airflow/pull/15577


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org