[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #38202: [SPARK-40763][K8S] Should expose driver service name to config for user features

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on code in PR #38202:
URL: https://github.com/apache/spark/pull/38202#discussion_r1039122836


##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverServiceFeatureStep.scala:
##########
@@ -50,6 +50,8 @@ private[spark] class DriverServiceFeatureStep(
       s"$shorterServiceName as the driver service's name.")
     shorterServiceName
   }
+  // expose driver service name
+  kubernetesConf.sparkConf.set(RESOLVED_SPARK_DRIVER_SVC_NAME, resolvedServiceName)

Review Comment:
   Thank you for update, @zwangsheng .
   
   BTW, this proposal looks exceptional because we have been using `kubernetesConf.sparkConf` as read-only until now. Is there any other instance where Apache Spark use `sparkConf` like this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org