You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "rzo1 (via GitHub)" <gi...@apache.org> on 2023/03/08 20:19:31 UTC
[GitHub] [storm] rzo1 opened a new pull request, #3522: STORM-3898 - Add Integration Test Github Action
rzo1 opened a new pull request, #3522:
URL: https://github.com/apache/storm/pull/3522
## What is the purpose of the change
- This re-adds the integration test in GitHub Actions similar to the one previously executed in Travis CI.
## How was the change tested
- Via GitHub actions on fork.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] bipinprasad commented on pull request #3522: STORM-3898 - Add Integration Test Github Action
Posted by "bipinprasad (via GitHub)" <gi...@apache.org>.
bipinprasad commented on PR #3522:
URL: https://github.com/apache/storm/pull/3522#issuecomment-1460949759
Thanks for adding and testing integration test. devtools travis directory and files should be renamed. Scripts sould also be renamed and one variable in then ..TRAVIS.. Separate Jira or this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] bipinprasad commented on pull request #3522: STORM-3898 - Add Integration Test Github Action
Posted by "bipinprasad (via GitHub)" <gi...@apache.org>.
bipinprasad commented on PR #3522:
URL: https://github.com/apache/storm/pull/3522#issuecomment-1461277129
Lets have this merged first. After fully functions github actions, the script paths and names can be tweaked: https://issues.apache.org/jira/browse/STORM-3899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] rzo1 commented on pull request #3522: STORM-3898 - Add Integration Test Github Action
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on PR #3522:
URL: https://github.com/apache/storm/pull/3522#issuecomment-1461803334
> Lets have this merged first. After fully functional github actions, the script paths and names can be tweaked: https://issues.apache.org/jira/browse/STORM-3899 The GitHub actions are fast as compared to Travis.
Great! Thanks for creating the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] bipinprasad merged pull request #3522: STORM-3898 - Add Integration Test Github Action
Posted by "bipinprasad (via GitHub)" <gi...@apache.org>.
bipinprasad merged PR #3522:
URL: https://github.com/apache/storm/pull/3522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] rzo1 commented on pull request #3522: STORM-3898 - Add Integration Test Github Action
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on PR #3522:
URL: https://github.com/apache/storm/pull/3522#issuecomment-1461267121
> Thanks for adding and testing integration test. devtools travis directory and files should be renamed. Scripts sould also be renamed and one variable in then ..TRAVIS.. Separate Jira or this one?
>
We need to remove the Travis file as well.
Maybe better to use a separate one for it to (a) rename or (b) remove any remaining links/comments/files/variables related to Travis. Might also be good to add a build badge in README. I
Starting from a fully green build is a good thing imho to avoid regressions :-)
But if you prefer this PR, I am also open to add the canges Here. Wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org