You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by jg...@apache.org on 2015/07/22 01:37:44 UTC

tomee git commit: PMD and checkstyle

Repository: tomee
Updated Branches:
  refs/heads/tomee-1.7.x f8d2800a2 -> 664a4d73b


PMD and checkstyle


Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/664a4d73
Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/664a4d73
Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/664a4d73

Branch: refs/heads/tomee-1.7.x
Commit: 664a4d73b2f3876646ebec36623919325006fc9a
Parents: f8d2800
Author: Jonathan Gallimore <jo...@jrg.me.uk>
Authored: Wed Jul 22 00:37:14 2015 +0100
Committer: Jonathan Gallimore <jo...@jrg.me.uk>
Committed: Wed Jul 22 00:37:14 2015 +0100

----------------------------------------------------------------------
 .../openejb/resource/jdbc/managed/local/ManagedConnection.java    | 2 +-
 .../openejb/resource/jdbc/managed/local/ManagedDataSource.java    | 3 ---
 2 files changed, 1 insertion(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tomee/blob/664a4d73/container/openejb-core/src/main/java/org/apache/openejb/resource/jdbc/managed/local/ManagedConnection.java
----------------------------------------------------------------------
diff --git a/container/openejb-core/src/main/java/org/apache/openejb/resource/jdbc/managed/local/ManagedConnection.java b/container/openejb-core/src/main/java/org/apache/openejb/resource/jdbc/managed/local/ManagedConnection.java
index 3fc6d78..859e445 100644
--- a/container/openejb-core/src/main/java/org/apache/openejb/resource/jdbc/managed/local/ManagedConnection.java
+++ b/container/openejb-core/src/main/java/org/apache/openejb/resource/jdbc/managed/local/ManagedConnection.java
@@ -273,7 +273,7 @@ public class ManagedConnection implements InvocationHandler {
                 return false;
             }
 
-            Key key = Key.class.cast(o);
+            final Key key = Key.class.cast(o);
             return (ds == key.ds || ds.equals(key.ds)) &&
                     !(user != null ? !user.equals(key.user) : key.user != null) &&
                     !(pwd != null ? !pwd.equals(key.pwd) : key.pwd != null);

http://git-wip-us.apache.org/repos/asf/tomee/blob/664a4d73/container/openejb-core/src/main/java/org/apache/openejb/resource/jdbc/managed/local/ManagedDataSource.java
----------------------------------------------------------------------
diff --git a/container/openejb-core/src/main/java/org/apache/openejb/resource/jdbc/managed/local/ManagedDataSource.java b/container/openejb-core/src/main/java/org/apache/openejb/resource/jdbc/managed/local/ManagedDataSource.java
index 82befc6..02bb881 100644
--- a/container/openejb-core/src/main/java/org/apache/openejb/resource/jdbc/managed/local/ManagedDataSource.java
+++ b/container/openejb-core/src/main/java/org/apache/openejb/resource/jdbc/managed/local/ManagedDataSource.java
@@ -17,13 +17,10 @@
 
 package org.apache.openejb.resource.jdbc.managed.local;
 
-import java.io.ObjectStreamException;
 import java.io.PrintWriter;
 import java.lang.reflect.Proxy;
 import java.sql.Connection;
 import java.sql.SQLException;
-import java.sql.SQLFeatureNotSupportedException;
-import java.util.logging.Logger;
 import javax.sql.CommonDataSource;
 import javax.sql.DataSource;
 import javax.transaction.TransactionManager;