You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/07/13 21:21:33 UTC

[GitHub] [iceberg] rdblue commented on pull request #1186: refactor avro reader and writer

rdblue commented on pull request #1186:
URL: https://github.com/apache/iceberg/pull/1186#issuecomment-657799919


   @chenjunjiedada, can you summarize the changes here in the PR description?
   
   Looks like this is primarily a rename, `DataReader` -> `AvroGenericReader`, using a base class, `BaseAvroGenericReader` for the read path. That name seems confusing to me because we now have `o.a.i.avro.GenericAvroReader` and `o.a.i.data.avro.AvroGenericReader`.
   
   I understand the goal of removing the reader for Avro generics. What is your plan to get there?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org