[jira] [Commented] (CALCITE-1028) Move populate materializations after sql-to-rel conversion

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066890#comment-15066890 ] 

Julian Hyde commented on CALCITE-1028:
--------------------------------------

* getMaterializations and getLattices could use some javadoc
* I generally don't use Override if I am implementing, not overriding, a method; and if I do use Override, I usually put it on the same line as the rest of the declaration
* is there a test case for the bug that was fixed by passing viewSchemaPath?

> Move populate materializations after sql-to-rel conversion
> ----------------------------------------------------------
>
>                 Key: CALCITE-1028
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1028
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Maryann Xue
>            Assignee: Maryann Xue
>            Priority: Minor
>              Labels: phoenix
>             Fix For: 1.6.0
>
>         Attachments: CALCITE-1028.patch
>
>
> This is to allow Phoenix to figure out which materializations are concerned with the query and thus have a chance to define them right before materializations are populated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)