[jira] [Commented] (MYFACES-3151) [perf] minimize ExternalContext.getInitParameter invocations in myfaces API

["Martin Kočí (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/MYFACES-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036374#comment-13036374 ] 

Martin Kočí commented on MYFACES-3151:
--------------------------------------

I renamed this issue to "... invocations in myfaces API"; 

The main problem in api is/was big amount of getInitParameter invocation in push/popComponent in/fromEL and getCurrent(Composite)Component ;
second one is in UINamingContainer - javax.faces.SEPARATOR_CHAR parameter

please review patches; if no objection i'll commit it to trunk (2.1) because HONOR_CURRENT_COMPONENT_ATTRIBUTES
is new in 2.1 and cause measurable performance degradation; patch reduces it.


> [perf] minimize ExternalContext.getInitParameter invocations in myfaces API
> ---------------------------------------------------------------------------
>
>                 Key: MYFACES-3151
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3151
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 2.1.0-SNAPSHOT
>         Environment: myfaces core trunk
>            Reporter: Martin Kočí
>            Assignee: Martin Kočí
>            Priority: Minor
>         Attachments: MYFACES-3151-ApplicationImpl.patch, MYFACES-3151-UIComponent.patch, MYFACES-3151-UINamingContainer.patch
>
>
> init-param from webapp context cannot change - it is sufficient read it once in constructor (ApplicationImpl for example)
> New problem (new in 2.1) is "great" javax.faces.HONOR_CURRENT_COMPONENT_ATTRIBUTES param for pushComponentToEL and popComponentFromEL - at least we can cache it in component (because push and pop are called more then ones during one lifecycle) and maybe cache it's value also in org.apache.myfaces.context.servlet.ServletExternalContextImplBase.getInitParameter(String)
> I have about ~ 90 000 invocations of getInitPaparameter in my test case in one request/response and that is not cheap.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira