You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/02/10 12:40:33 UTC
[GitHub] [incubator-dolphinscheduler] Technoboy- opened a new pull request
#1926: Refactor architecture
Technoboy- opened a new pull request #1926: Refactor architecture
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1926
## *Tips*
- *Thanks very much for contributing to Apache DolphinScheduler.*
- *Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds checkstyle plugin.)*
## Brief change log
*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1926: Refactor architecture
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1926: Refactor architecture
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1926#issuecomment-584105040
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926?src=pr&el=h1) Report
> Merging [#1926](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926?src=pr&el=desc) into [refactor-architecture](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/8b35c4c78580ecb7ac3b5b456bf947bc82fe3a46?src=pr&el=desc) will **decrease** coverage by `1.46%`.
> The diff coverage is `2.94%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## refactor-architecture #1926 +/- ##
=========================================================
- Coverage 25.19% 23.72% -1.47%
=========================================================
Files 298 323 +25
Lines 14330 14773 +443
Branches 2350 2397 +47
=========================================================
- Hits 3610 3505 -105
- Misses 10268 10851 +583
+ Partials 452 417 -35
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...olphinscheduler/service/queue/TaskQueueZkImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvcXVldWUvVGFza1F1ZXVlWmtJbXBsLmphdmE=) | `0% <ø> (ø)` | |
| [.../dolphinscheduler/service/zk/AbstractZKClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvemsvQWJzdHJhY3RaS0NsaWVudC5qYXZh) | `0% <ø> (ø)` | |
| [...nscheduler/service/zk/DefaultEnsembleProvider.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvemsvRGVmYXVsdEVuc2VtYmxlUHJvdmlkZXIuamF2YQ==) | `0% <ø> (ø)` | |
| [...dolphinscheduler/server/monitor/ZKMonitorImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21vbml0b3IvWktNb25pdG9ySW1wbC5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...uler/api/controller/ProcessInstanceController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvUHJvY2Vzc0luc3RhbmNlQ29udHJvbGxlci5qYXZh) | `1.23% <ø> (ø)` | :arrow_up: |
| [...inscheduler/service/quartz/cron/AbstractCycle.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvcXVhcnR6L2Nyb24vQWJzdHJhY3RDeWNsZS5qYXZh) | `0% <ø> (ø)` | |
| [...uler/remote/command/ExecuteTaskRequestCommand.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbW1hbmQvRXhlY3V0ZVRhc2tSZXF1ZXN0Q29tbWFuZC5qYXZh) | `0% <ø> (ø)` | |
| [...lphinscheduler/service/quartz/QuartzExecutors.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvcXVhcnR6L1F1YXJ0ekV4ZWN1dG9ycy5qYXZh) | `0% <ø> (ø)` | |
| [...he/dolphinscheduler/server/utils/RemoveZKNode.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1JlbW92ZVpLTm9kZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...phinscheduler/api/service/TaskInstanceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGFza0luc3RhbmNlU2VydmljZS5qYXZh) | `2.63% <ø> (ø)` | :arrow_up: |
| ... and [101 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926?src=pr&el=footer). Last update [8b35c4c...dc75521](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue
#1926: Refactor architecture
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #1926: Refactor architecture
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1926#issuecomment-584109400
SonarCloud Quality Gate failed.
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1926&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1926&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1926&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1926&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1926&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1926&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1926&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1926&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1926&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1926&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1926&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='2.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1926&metric=new_coverage&view=list) [2.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1926&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1926&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1926&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1926:
Refactor architecture
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1926: Refactor architecture
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1926#issuecomment-584105040
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926?src=pr&el=h1) Report
> Merging [#1926](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926?src=pr&el=desc) into [refactor-architecture](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/8b35c4c78580ecb7ac3b5b456bf947bc82fe3a46?src=pr&el=desc) will **decrease** coverage by `1.46%`.
> The diff coverage is `2.95%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## refactor-architecture #1926 +/- ##
=========================================================
- Coverage 25.19% 23.72% -1.47%
=========================================================
Files 298 323 +25
Lines 14330 14771 +441
Branches 2350 2397 +47
=========================================================
- Hits 3610 3505 -105
- Misses 10268 10849 +581
+ Partials 452 417 -35
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...olphinscheduler/service/queue/TaskQueueZkImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvcXVldWUvVGFza1F1ZXVlWmtJbXBsLmphdmE=) | `0% <ø> (ø)` | |
| [.../dolphinscheduler/service/zk/AbstractZKClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvemsvQWJzdHJhY3RaS0NsaWVudC5qYXZh) | `0% <ø> (ø)` | |
| [...nscheduler/service/zk/DefaultEnsembleProvider.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvemsvRGVmYXVsdEVuc2VtYmxlUHJvdmlkZXIuamF2YQ==) | `0% <ø> (ø)` | |
| [...dolphinscheduler/server/monitor/ZKMonitorImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21vbml0b3IvWktNb25pdG9ySW1wbC5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...uler/api/controller/ProcessInstanceController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvUHJvY2Vzc0luc3RhbmNlQ29udHJvbGxlci5qYXZh) | `1.23% <ø> (ø)` | :arrow_up: |
| [...inscheduler/service/quartz/cron/AbstractCycle.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvcXVhcnR6L2Nyb24vQWJzdHJhY3RDeWNsZS5qYXZh) | `0% <ø> (ø)` | |
| [...uler/remote/command/ExecuteTaskRequestCommand.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbW1hbmQvRXhlY3V0ZVRhc2tSZXF1ZXN0Q29tbWFuZC5qYXZh) | `0% <ø> (ø)` | |
| [...lphinscheduler/service/quartz/QuartzExecutors.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvcXVhcnR6L1F1YXJ0ekV4ZWN1dG9ycy5qYXZh) | `0% <ø> (ø)` | |
| [...he/dolphinscheduler/server/utils/RemoveZKNode.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1JlbW92ZVpLTm9kZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...phinscheduler/api/service/TaskInstanceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGFza0luc3RhbmNlU2VydmljZS5qYXZh) | `2.63% <ø> (ø)` | :arrow_up: |
| ... and [100 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926?src=pr&el=footer). Last update [8b35c4c...dc75521](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1926: Refactor architecture
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1926: Refactor architecture
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1926#issuecomment-584105040
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926?src=pr&el=h1) Report
> Merging [#1926](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926?src=pr&el=desc) into [refactor-architecture](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/8b35c4c78580ecb7ac3b5b456bf947bc82fe3a46?src=pr&el=desc) will **decrease** coverage by `1.46%`.
> The diff coverage is `2.94%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## refactor-architecture #1926 +/- ##
=========================================================
- Coverage 25.19% 23.72% -1.47%
=========================================================
Files 298 323 +25
Lines 14330 14773 +443
Branches 2350 2397 +47
=========================================================
- Hits 3610 3505 -105
- Misses 10268 10851 +583
+ Partials 452 417 -35
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...olphinscheduler/service/queue/TaskQueueZkImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvcXVldWUvVGFza1F1ZXVlWmtJbXBsLmphdmE=) | `0% <ø> (ø)` | |
| [.../dolphinscheduler/service/zk/AbstractZKClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvemsvQWJzdHJhY3RaS0NsaWVudC5qYXZh) | `0% <ø> (ø)` | |
| [...nscheduler/service/zk/DefaultEnsembleProvider.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvemsvRGVmYXVsdEVuc2VtYmxlUHJvdmlkZXIuamF2YQ==) | `0% <ø> (ø)` | |
| [...dolphinscheduler/server/monitor/ZKMonitorImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21vbml0b3IvWktNb25pdG9ySW1wbC5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...uler/api/controller/ProcessInstanceController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvUHJvY2Vzc0luc3RhbmNlQ29udHJvbGxlci5qYXZh) | `1.23% <ø> (ø)` | :arrow_up: |
| [...inscheduler/service/quartz/cron/AbstractCycle.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvcXVhcnR6L2Nyb24vQWJzdHJhY3RDeWNsZS5qYXZh) | `0% <ø> (ø)` | |
| [...uler/remote/command/ExecuteTaskRequestCommand.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbW1hbmQvRXhlY3V0ZVRhc2tSZXF1ZXN0Q29tbWFuZC5qYXZh) | `0% <ø> (ø)` | |
| [...lphinscheduler/service/quartz/QuartzExecutors.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvcXVhcnR6L1F1YXJ0ekV4ZWN1dG9ycy5qYXZh) | `0% <ø> (ø)` | |
| [...he/dolphinscheduler/server/utils/RemoveZKNode.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1JlbW92ZVpLTm9kZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...phinscheduler/api/service/TaskInstanceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGFza0luc3RhbmNlU2VydmljZS5qYXZh) | `2.63% <ø> (ø)` | :arrow_up: |
| ... and [101 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926?src=pr&el=footer). Last update [8b35c4c...dc75521](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1926?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1926:
Refactor architecture
Posted by GitBox <gi...@apache.org>.
qiaozhanwei merged pull request #1926: Refactor architecture
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1926
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services