You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ja...@apache.org on 2020/03/23 19:27:38 UTC

[incubator-pinot] 08/09: fix another test

This is an automated email from the ASF dual-hosted git repository.

jamesshao pushed a commit to branch upsert-refactor
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git

commit c793323014dea912ef277b997419798dca51e9c6
Author: james Shao <sj...@uber.com>
AuthorDate: Wed Feb 26 11:37:25 2020 -0800

    fix another test
---
 .../MutableSegmentImplAggregateMetricsTest.java    | 46 +++++++++++++++++++++-
 1 file changed, 44 insertions(+), 2 deletions(-)

diff --git a/pinot-core/src/test/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImplAggregateMetricsTest.java b/pinot-core/src/test/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImplAggregateMetricsTest.java
index e08e6b3..e6bc499 100644
--- a/pinot-core/src/test/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImplAggregateMetricsTest.java
+++ b/pinot-core/src/test/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImplAggregateMetricsTest.java
@@ -26,6 +26,13 @@ import java.util.Map;
 import java.util.Random;
 import java.util.concurrent.TimeUnit;
 import org.apache.commons.lang.RandomStringUtils;
+import org.apache.pinot.core.io.reader.DataFileReader;
+import org.apache.pinot.core.segment.index.ColumnMetadata;
+import org.apache.pinot.core.segment.index.column.ColumnIndexContainer;
+import org.apache.pinot.core.segment.index.readers.Dictionary;
+import org.apache.pinot.core.segment.index.readers.InvertedIndexReader;
+import org.apache.pinot.core.segment.virtualcolumn.VirtualColumnContext;
+import org.apache.pinot.core.segment.virtualcolumn.VirtualColumnProvider;
 import org.apache.pinot.spi.data.DimensionFieldSpec;
 import org.apache.pinot.spi.data.FieldSpec;
 import org.apache.pinot.spi.data.MetricFieldSpec;
@@ -58,10 +65,10 @@ public class MutableSegmentImplAggregateMetricsTest {
         .build();
     // Add virtual columns, which should not be aggregated
     DimensionFieldSpec virtualDimensionFieldSpec =
-        new DimensionFieldSpec("$virtualDimension", FieldSpec.DataType.INT, true, Object.class);
+        new DimensionFieldSpec("$virtualDimension", FieldSpec.DataType.INT, true, mockVCProvider.class);
     schema.addField(virtualDimensionFieldSpec);
     MetricFieldSpec virtualMetricFieldSpec = new MetricFieldSpec("$virtualMetric", FieldSpec.DataType.INT);
-    virtualMetricFieldSpec.setVirtualColumnProvider("provider.class");
+    virtualMetricFieldSpec.setVirtualColumnProvider(mockVCProvider.class.getName());
     schema.addField(virtualMetricFieldSpec);
 
     _mutableSegmentImpl = MutableSegmentImplTestUtils
@@ -127,4 +134,39 @@ public class MutableSegmentImplAggregateMetricsTest {
   public void tearDown() {
     _mutableSegmentImpl.destroy();
   }
+
+  public static class mockVCProvider implements VirtualColumnProvider {
+
+    public mockVCProvider() {}
+
+    @Override
+    public DataFileReader buildReader(VirtualColumnContext context) {
+      return null;
+    }
+
+    @Override
+    public Dictionary buildDictionary(VirtualColumnContext context) {
+      return null;
+    }
+
+    @Override
+    public ColumnMetadata buildMetadata(VirtualColumnContext context) {
+      return null;
+    }
+
+    @Override
+    public InvertedIndexReader buildInvertedIndex(VirtualColumnContext context) {
+      return null;
+    }
+
+    @Override
+    public ColumnIndexContainer buildColumnIndexContainer(VirtualColumnContext context) {
+      return null;
+    }
+
+    @Override
+    public ColumnIndexContainer buildColumnIndexContainer(VirtualColumnContext context, DataFileReader reader, Dictionary dictionary, InvertedIndexReader invertedIndexReader) {
+      return null;
+    }
+  }
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org