You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Jason Dillon <ja...@planet57.com> on 2006/08/20 09:44:29 UTC
Disallow 1.5 on trunk (until its actually supported)?
I keep running into problems switching my local jdk (ala setjdk) from
1.4 to 1.5 and forgetting to switch it back again when making G builds.
I though it would be nice if the build would fail early if I had the
wrong JDK configured. So, I wroke a require-java-version goal in a
new tools-maven-plugin (in Genesis), which allows the build to fail
early. It uses Mac OS X-style version suffix tokens (+ and *) to
allow selection.
http://geronimo.apache.org/maven/genesis/plugins/tools-maven-
plugin/usage.html
I've set it up for GShell which needs 1.5, but I was wondering if we
should configure this goal in trunk and set it to 1.4* so that if you
are using 1.5 it will puke early with a meaningful error.
Seems like folks who build with 1.5 run into errors... so maybe its a
good thing to force 1.4?
Thoughts?
--jason
Re: Disallow 1.5 on trunk (until its actually supported)?
Posted by Bill Dudney <bd...@apache.org>.
Problem is that the 1.5 jdk does not include the sun orb so compile
fails, but not till late in the build
+1 from me
-bd-
On Aug 20, 2006, at 11:36 AM, Alan D. Cabrera wrote:
> Jason Dillon wrote:
>> I keep running into problems switching my local jdk (ala setjdk)
>> from 1.4 to 1.5 and forgetting to switch it back again when making
>> G builds.
>>
>> I though it would be nice if the build would fail early if I had
>> the wrong JDK configured. So, I wroke a require-java-version goal
>> in a new tools-maven-plugin (in Genesis), which allows the build
>> to fail early. It uses Mac OS X-style version suffix tokens (+
>> and *) to allow selection.
>>
>> http://geronimo.apache.org/maven/genesis/plugins/tools-maven-
>> plugin/usage.html
>>
>> I've set it up for GShell which needs 1.5, but I was wondering if
>> we should configure this goal in trunk and set it to 1.4* so that
>> if you are using 1.5 it will puke early with a meaningful error.
>>
>> Seems like folks who build with 1.5 run into errors... so maybe
>> its a good thing to force 1.4?
>>
>> Thoughts?
>>
>> --jason
>>
>>
> Why not just add the following to the POMs?
>
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> <configuration>
> <source>1.4</source>
> <target>1.4</target>
> </configuration>
> </plugin>
> </plugins>
>
>
> Regards,
> Alan
>
>
Re: Disallow 1.5 on trunk (until its actually supported)?
Posted by Jason Dillon <ja...@planet57.com>.
Okay, I'm going to commit this.
If anyone see anything strange, like you are using a 1.4 JDK and it
complains please let me know right away and I will fix and/or back-
out this change.
--jason
On Aug 21, 2006, at 5:34 PM, Alan Cabrera wrote:
> Thanks for pointing this out for me. It seems like a reasonable idea.
>
>
> Regards,
> Alan
>
> Jason Dillon wrote:
>> We already have this... this just means that compiles will
>> continue to gen 1.4 bytecode. Some tests have been known to fail
>> because they were run with 1.5, and then all that orb stuff. We
>> warn everyone all over the place to not use 1.5 with G right
>> now... figured we should just enforce it at a build level.
>>
>> Going forward I think we are gonna need this anyways, as it seems
>> that when sun releases a new version that it tends to break things...
>>
>> --jason
>>
>>
>> On Aug 20, 2006, at 10:36 AM, Alan D. Cabrera wrote:
>>
>>> Jason Dillon wrote:
>>>> I keep running into problems switching my local jdk (ala setjdk)
>>>> from 1.4 to 1.5 and forgetting to switch it back again when
>>>> making G builds.
>>>>
>>>> I though it would be nice if the build would fail early if I had
>>>> the wrong JDK configured. So, I wroke a require-java-version
>>>> goal in a new tools-maven-plugin (in Genesis), which allows the
>>>> build to fail early. It uses Mac OS X-style version suffix
>>>> tokens (+ and *) to allow selection.
>>>>
>>>> http://geronimo.apache.org/maven/genesis/plugins/tools-maven-
>>>> plugin/usage.html
>>>>
>>>> I've set it up for GShell which needs 1.5, but I was wondering
>>>> if we should configure this goal in trunk and set it to 1.4* so
>>>> that if you are using 1.5 it will puke early with a meaningful
>>>> error.
>>>>
>>>> Seems like folks who build with 1.5 run into errors... so maybe
>>>> its a good thing to force 1.4?
>>>>
>>>> Thoughts?
>>>>
>>>> --jason
>>>>
>>>>
>>> Why not just add the following to the POMs?
>>>
>>> <plugins>
>>> <plugin>
>>> <groupId>org.apache.maven.plugins</groupId>
>>> <artifactId>maven-compiler-plugin</artifactId>
>>> <configuration>
>>> <source>1.4</source>
>>> <target>1.4</target>
>>> </configuration>
>>> </plugin>
>>> </plugins>
>>>
>>>
>>> Regards,
>>> Alan
>>>
>>>
>>
>
Re: Disallow 1.5 on trunk (until its actually supported)?
Posted by Alan Cabrera <li...@toolazydogs.com>.
Thanks for pointing this out for me. It seems like a reasonable idea.
Regards,
Alan
Jason Dillon wrote:
> We already have this... this just means that compiles will continue to
> gen 1.4 bytecode. Some tests have been known to fail because they
> were run with 1.5, and then all that orb stuff. We warn everyone all
> over the place to not use 1.5 with G right now... figured we should
> just enforce it at a build level.
>
> Going forward I think we are gonna need this anyways, as it seems that
> when sun releases a new version that it tends to break things...
>
> --jason
>
>
> On Aug 20, 2006, at 10:36 AM, Alan D. Cabrera wrote:
>
>> Jason Dillon wrote:
>>> I keep running into problems switching my local jdk (ala setjdk)
>>> from 1.4 to 1.5 and forgetting to switch it back again when making G
>>> builds.
>>>
>>> I though it would be nice if the build would fail early if I had the
>>> wrong JDK configured. So, I wroke a require-java-version goal in a
>>> new tools-maven-plugin (in Genesis), which allows the build to fail
>>> early. It uses Mac OS X-style version suffix tokens (+ and *) to
>>> allow selection.
>>>
>>>
>>> http://geronimo.apache.org/maven/genesis/plugins/tools-maven-plugin/usage.html
>>>
>>>
>>> I've set it up for GShell which needs 1.5, but I was wondering if we
>>> should configure this goal in trunk and set it to 1.4* so that if
>>> you are using 1.5 it will puke early with a meaningful error.
>>>
>>> Seems like folks who build with 1.5 run into errors... so maybe its
>>> a good thing to force 1.4?
>>>
>>> Thoughts?
>>>
>>> --jason
>>>
>>>
>> Why not just add the following to the POMs?
>>
>> <plugins>
>> <plugin>
>> <groupId>org.apache.maven.plugins</groupId>
>> <artifactId>maven-compiler-plugin</artifactId>
>> <configuration>
>> <source>1.4</source>
>> <target>1.4</target>
>> </configuration>
>> </plugin>
>> </plugins>
>>
>>
>> Regards,
>> Alan
>>
>>
>
Re: Disallow 1.5 on trunk (until its actually supported)?
Posted by Jason Dillon <ja...@planet57.com>.
We already have this... this just means that compiles will continue
to gen 1.4 bytecode. Some tests have been known to fail because they
were run with 1.5, and then all that orb stuff. We warn everyone all
over the place to not use 1.5 with G right now... figured we should
just enforce it at a build level.
Going forward I think we are gonna need this anyways, as it seems
that when sun releases a new version that it tends to break things...
--jason
On Aug 20, 2006, at 10:36 AM, Alan D. Cabrera wrote:
> Jason Dillon wrote:
>> I keep running into problems switching my local jdk (ala setjdk)
>> from 1.4 to 1.5 and forgetting to switch it back again when making
>> G builds.
>>
>> I though it would be nice if the build would fail early if I had
>> the wrong JDK configured. So, I wroke a require-java-version goal
>> in a new tools-maven-plugin (in Genesis), which allows the build
>> to fail early. It uses Mac OS X-style version suffix tokens (+
>> and *) to allow selection.
>>
>> http://geronimo.apache.org/maven/genesis/plugins/tools-maven-
>> plugin/usage.html
>>
>> I've set it up for GShell which needs 1.5, but I was wondering if
>> we should configure this goal in trunk and set it to 1.4* so that
>> if you are using 1.5 it will puke early with a meaningful error.
>>
>> Seems like folks who build with 1.5 run into errors... so maybe
>> its a good thing to force 1.4?
>>
>> Thoughts?
>>
>> --jason
>>
>>
> Why not just add the following to the POMs?
>
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> <configuration>
> <source>1.4</source>
> <target>1.4</target>
> </configuration>
> </plugin>
> </plugins>
>
>
> Regards,
> Alan
>
>
Re: Disallow 1.5 on trunk (until its actually supported)?
Posted by "Alan D. Cabrera" <li...@toolazydogs.com>.
Jason Dillon wrote:
> I keep running into problems switching my local jdk (ala setjdk) from
> 1.4 to 1.5 and forgetting to switch it back again when making G builds.
>
> I though it would be nice if the build would fail early if I had the
> wrong JDK configured. So, I wroke a require-java-version goal in a
> new tools-maven-plugin (in Genesis), which allows the build to fail
> early. It uses Mac OS X-style version suffix tokens (+ and *) to
> allow selection.
>
>
> http://geronimo.apache.org/maven/genesis/plugins/tools-maven-plugin/usage.html
>
>
> I've set it up for GShell which needs 1.5, but I was wondering if we
> should configure this goal in trunk and set it to 1.4* so that if you
> are using 1.5 it will puke early with a meaningful error.
>
> Seems like folks who build with 1.5 run into errors... so maybe its a
> good thing to force 1.4?
>
> Thoughts?
>
> --jason
>
>
Why not just add the following to the POMs?
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<source>1.4</source>
<target>1.4</target>
</configuration>
</plugin>
</plugins>
Regards,
Alan
Re: Disallow 1.5 on trunk (until its actually supported)?
Posted by Jason Dillon <ja...@planet57.com>.
I added a skip flag... and I have not tried, but you should be able
to create a profiles.xml to set that flag.
--jason
On Aug 20, 2006, at 1:07 AM, Jacek Laskowski wrote:
> On 8/20/06, Jason Dillon <ja...@planet57.com> wrote:
>
>> Seems like folks who build with 1.5 run into errors... so maybe its a
>> good thing to force 1.4?
>
> One more thing, it would be good to introduce a setting to turn it on
> for people who want to migrate Geronimo to Java 5.
>
> Jacek
>
> --
> Jacek Laskowski
> http://www.laskowski.net.pl
Re: Disallow 1.5 on trunk (until its actually supported)?
Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On 8/20/06, Jason Dillon <ja...@planet57.com> wrote:
> Seems like folks who build with 1.5 run into errors... so maybe its a
> good thing to force 1.4?
One more thing, it would be good to introduce a setting to turn it on
for people who want to migrate Geronimo to Java 5.
Jacek
--
Jacek Laskowski
http://www.laskowski.net.pl
Re: Disallow 1.5 on trunk (until its actually supported)?
Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On 8/20/06, Jason Dillon <ja...@planet57.com> wrote:
> Thoughts?
Good idea! I had to create some aliases to work with the project and
I'm not facing the issue anymore, but I'm sure there're others (if not
all) who work with both, so the sooner they know they use incorrect
jvm during the build the better (whoops, it seems to have become
old-fasioned and should've been used "merrier" ;-))
Jacek
--
Jacek Laskowski
http://www.laskowski.net.pl
Re: Disallow 1.5 on trunk (until its actually supported)?
Posted by Gianny Damour <gi...@optusnet.com.au>.
+1
Gianny
On 20/08/2006, at 5:44 PM, Jason Dillon wrote:
> I keep running into problems switching my local jdk (ala setjdk)
> from 1.4 to 1.5 and forgetting to switch it back again when making
> G builds.
>
> I though it would be nice if the build would fail early if I had
> the wrong JDK configured. So, I wroke a require-java-version goal
> in a new tools-maven-plugin (in Genesis), which allows the build to
> fail early. It uses Mac OS X-style version suffix tokens (+ and *)
> to allow selection.
>
> http://geronimo.apache.org/maven/genesis/plugins/tools-maven-
> plugin/usage.html
>
> I've set it up for GShell which needs 1.5, but I was wondering if
> we should configure this goal in trunk and set it to 1.4* so that
> if you are using 1.5 it will puke early with a meaningful error.
>
> Seems like folks who build with 1.5 run into errors... so maybe its
> a good thing to force 1.4?
>
> Thoughts?
>
> --jason
>
>