[GitHub] [beam] je-ik commented on a change in pull request #15540: Allow for DoFn#getAllowedTimestampSkew() when checking the output timestamp

[GitBox <gi...@apache.org>]

je-ik commented on a change in pull request #15540:
URL: https://github.com/apache/beam/pull/15540#discussion_r712816378



##########
File path: runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java
##########
@@ -1190,12 +1190,12 @@ public Timer withOutputTimestamp(Instant outputTimestamp) {
      * </ul>
      */
     private void setAndVerifyOutputTimestamp() {
-
       if (outputTimestamp != null) {
         checkArgument(
-            !outputTimestamp.isBefore(elementInputTimestamp),
-            "output timestamp %s should be after input message timestamp or output timestamp of firing timers %s",
+            !outputTimestamp.plus(fn.getAllowedTimestampSkew()).isBefore(elementInputTimestamp),

Review comment:
       We should probably explicitly handle Long.MAX_VALUE here to make sure it does not overflow. Or is that handled by the Instant itself?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org