You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/09/03 14:05:01 UTC

[GitHub] [airflow] zxzl commented on issue #5559: [AIRFLOW-4930] Send druid ingestion spec as data, not json

zxzl commented on issue #5559: [AIRFLOW-4930] Send druid ingestion spec as data, not json
URL: https://github.com/apache/airflow/pull/5559#issuecomment-527473499
 
 
   @awelsh93 Thanks for letting me know relevant comment and previous issues. 
   
   Yes I agree with https://github.com/apache/airflow/pull/3633#issuecomment-458586850 - druid operator passes json string (https://github.com/happyjulie/incubator-airflow/blob/d2b4035ee53db0751c87d390833afeefd6902084/airflow/contrib/operators/druid_operator.py#L61) but `json=` parameter in requests is for encoding dicts. 
   
   I think it will be better if druid operator passes just dict loaded from json.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services