Re: Review Request 10882: CLOUDSTACK-2178 : "Add guest network" button is not responding

[Saksham Srivastava <sa...@citrix.com>]

> On May 4, 2013, 8:48 p.m., Pranav Saxena wrote:
> > Review comment on the corresponding JIRA ticket to verify if its actually a valid bug . If yes , then we'll definitely proceed with validating the fix . Thanks !

Hi Issac, CLOUDSTACK-2178  is marked closed as invalid.
Do we still need this fix ? If no then you can discard this review request.


- Saksham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10882/#review20169
-----------------------------------------------------------


On May 10, 2013, 7:37 a.m., Isaac Chiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10882/
> -----------------------------------------------------------
> 
> (Updated May 10, 2013, 7:37 a.m.)
> 
> 
> Review request for cloudstack and Pranav Saxena.
> 
> 
> Bugs: CLOUDSTACK-2178
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The root cause of the issue is that the makeForm function in dialog.js cannot work with dependsOn field correctly.
> 
> Changed :
> 1. Dialog.js     : Modify makeForm function in Dialog.js to work correctly with "dependsOn" field.
> 2. Network.js : Add checking for response in the call back function.
> 
> 
> Diffs
> -----
> 
>   ui/scripts/network.js 6b310ce 
>   ui/scripts/ui/dialog.js bb372fb 
> 
> Diff: https://reviews.apache.org/r/10882/diff/
> 
> 
> Testing
> -------
> 
> Test from ui ans work well
> 
> 
> Thanks,
> 
> Isaac Chiang
> 
>