[GitHub] [samza] prateekm commented on a change in pull request #1117: [SAMZA-2283] Samza Sql Diagnostics: make latency metrics changes backward compatible

[GitBox <gi...@apache.org>]

prateekm commented on a change in pull request #1117: [SAMZA-2283] Samza Sql Diagnostics: make latency metrics changes backward compatible
URL: https://github.com/apache/samza/pull/1117#discussion_r307944439
 
 

 ##########
 File path: samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.java
 ##########
 @@ -92,21 +92,55 @@ public IncomingMessageEnvelope(SystemStreamPartition systemStreamPartition, Stri
   }
 
   /**
-   * Getter for event time
+   * Getter for event time (Nanos)
    * @return this.eventTime
    */
-  public long getEventTime() {
+  public long getEventTimeNanos() {
 
 Review comment:
   Have you seen scenarios where event time is in nanos? It's not common to have nanosecond resolution clocks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services