You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Joerg Heinicke <jo...@gmx.de> on 2004/04/14 20:39:35 UTC
some Eclipse compiler warnings
javaflow block:
The private field Continuation.parent is never read locally
src/blocks/javaflow/java/org/apache/cocoon/components/flow/java/Continuation.java
line 30
=> parent is only needed in the constructor => remove the field
The private field FormInstance.submitId is never read locally
src/blocks/javaflow/java/org/apache/cocoon/forms/flow/java/FormInstance.java
line 50
=> do not really know
The local variable form is never read
src/blocks/javaflow/java/org/apache/cocoon/forms/flow/java/FormInstance.java
line 97
=> this.form = formMgr.createForm(formDefinition);
=> what about this.form vs. formWidget ?? => remove formWidget
slide block:
The private method getChildByPath(String) from the type SourceDTO is
never used locally
src/blocks/slide/java/org/apache/cocoon/components/source/SourceDTO.java
line 327
=> remove it
webdav block:
The private field WebDAVRepositoryPropertyHelper.manager is never read
locally
src/blocks/webdav/java/org/apache/cocoon/components/repository/impl/WebDAVRepositoryPropertyHelper.java
line 49
=> remove manager, don't implement Serviceable, Disposable ??
The private field WebDAVRepositoryPropertyHelper.credentials is never
read locally
src/blocks/webdav/java/org/apache/cocoon/components/repository/impl/WebDAVRepositoryPropertyHelper.java
line 55
=> do not really know
The private field WebDAVRepositoryTransactionHelper.manager is never
read locally
src/blocks/webdav/java/org/apache/cocoon/components/repository/impl/WebDAVRepositoryTransactionHelper.java
line 39
=> remove manager, don't implement Serviceable, Disposable ??
The private field WebDAVRepositoryVersioningHelper.manager is never read
locally
src/blocks/webdav/java/org/apache/cocoon/components/repository/impl/WebDAVRepositoryVersioningHelper.java
line 40
=> remove manager, don't implement Serviceable, Disposable ??
The private field WebDAVRepositoryVersioningHelper.credentials is never
read locally
src/blocks/webdav/java/org/apache/cocoon/components/repository/impl/WebDAVRepositoryVersioningHelper.java
line 46
=> do not really know
The local variable sourceURL is never read
src/blocks/webdav/java/org/apache/cocoon/components/webdav/WebDAVUtil.java
line 79
=> I guess the statement itself (new HttpURL(uri);) is needed for
enforcing errors, but not the local variable => remove it ?
Any comments??
Joerg