You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "sreeram-venkitesh (via GitHub)" <gi...@apache.org> on 2024/11/01 16:47:50 UTC
[PR] Added lrucache to cache expression result for chaitin-waf plugin [apisix]
sreeram-venkitesh opened a new pull request, #11705:
URL: https://github.com/apache/apisix/pull/11705
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixes part of #9945
#9945 includes 3 tasks. One of them is caching the expression result in the plugin code. This PR attempts to fix this part of the issue. I would love to get feedback to understand if I'm on the right path here.
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added lrucache to cache expression result for chaitin-waf plugin [apisix]
Posted by "sreeram-venkitesh (via GitHub)" <gi...@apache.org>.
sreeram-venkitesh commented on PR #11705:
URL: https://github.com/apache/apisix/pull/11705#issuecomment-2798935297
Closed in https://github.com/apache/apisix/pull/12029, this PR is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added lrucache to cache expression result for chaitin-waf plugin [apisix]
Posted by "sreeram-venkitesh (via GitHub)" <gi...@apache.org>.
sreeram-venkitesh closed pull request #11705: Added lrucache to cache expression result for chaitin-waf plugin
URL: https://github.com/apache/apisix/pull/11705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added lrucache to cache expression result for chaitin-waf plugin [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11705:
URL: https://github.com/apache/apisix/pull/11705#issuecomment-2746125644
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added lrucache to cache expression result for chaitin-waf plugin [apisix]
Posted by "membphis (via GitHub)" <gi...@apache.org>.
membphis commented on PR #11705:
URL: https://github.com/apache/apisix/pull/11705#issuecomment-2558773322
@sreeram-venkitesh thx for your PR first, and pls take some time to update the PR's title
<img width="1045" alt="image" src="https://github.com/user-attachments/assets/c7191e50-b357-435a-bee6-cf5815f4c8a4" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org