You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/11/21 02:58:58 UTC

[GitHub] [inlong] gong commented on a diff in pull request #6580: [INLONG-6578][Sort] Fix the write failure after the Doris sets 'sink.properties.columns' option

gong commented on code in PR #6580:
URL: https://github.com/apache/inlong/pull/6580#discussion_r1027502591


##########
inlong-sort/sort-connectors/doris/src/main/java/org/apache/inlong/sort/doris/table/DorisDynamicTableSink.java:
##########
@@ -125,5 +143,14 @@ public DynamicTableSink copy() {
     public String asSummaryString() {
         return "Doris Table Sink Of InLong";
     }
+
+    private boolean enableBatchDelete() {
+        try {
+            Schema schema = RestService.getSchema(options, readOptions, LOG);
+            return executionOptions.getEnableDelete() || UNIQUE_KEYS_TYPE.equals(schema.getKeysType());
+        } catch (DorisException e) {
+            throw new RuntimeException("Failed fetch doris table schema: " + options.getTableIdentifier());
+        }

Review Comment:
   I suggest print original `DorisException`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org