[GitHub] [superset] AAfghahi commented on a change in pull request #13016: refactor: HighlightSql to Functional Component

[GitBox <gi...@apache.org>]

AAfghahi commented on a change in pull request #13016:
URL: https://github.com/apache/superset/pull/13016#discussion_r572451398



##########
File path: superset-frontend/src/SqlLab/components/HighlightedSql.jsx
##########
@@ -41,77 +41,66 @@ const propTypes = {
   shrink: PropTypes.bool,
 };
 
-class HighlightedSql extends React.Component {
-  constructor(props) {
-    super(props);
-    this.state = {
-      modalBody: null,
-    };
-  }
+function HighlightedSql({ sql, rawSql, maxWidth, maxLines, shrink }) {

Review comment:
       Ok, I will get to these tonight. Thank you!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org