You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by GitBox <gi...@apache.org> on 2022/12/13 18:58:03 UTC
[GitHub] [age] Hunaid2000 opened a new pull request, #389: Issue #388 - Fix python driver build from source
Hunaid2000 opened a new pull request, #389:
URL: https://github.com/apache/age/pull/389
See details in issue #388.
- Changed required version of antlr4-python3-runtime to 4.9.3
- Moved required packages to requirements.txt so that user can easily install all packages with one command
- Updated the readme accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] dehowef merged pull request #389: Issue #388 - Fix python driver build from source
Posted by GitBox <gi...@apache.org>.
dehowef merged PR #389:
URL: https://github.com/apache/age/pull/389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] dehowef commented on pull request #389: Issue #388 - Fix python driver build from source
Posted by GitBox <gi...@apache.org>.
dehowef commented on PR #389:
URL: https://github.com/apache/age/pull/389#issuecomment-1371770780
@Hunaid2000 That's great! We can go ahead and close it and merge the changes then. Thank you for your time and effort!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] dehowef commented on pull request #389: Issue #388 - Fix python driver build from source
Posted by GitBox <gi...@apache.org>.
dehowef commented on PR #389:
URL: https://github.com/apache/age/pull/389#issuecomment-1370489339
@Hunaid2000 Your changes look good-- Before I approve these changes, were you able to get the python driver to compile with these changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani commented on pull request #389: Issue #388 - Fix python driver build from source
Posted by GitBox <gi...@apache.org>.
jrgemignani commented on PR #389:
URL: https://github.com/apache/age/pull/389#issuecomment-1370081736
@Hunaid2000 Looks good to me.
@dehowef I will let you give it a final review and merge if acceptable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] Hunaid2000 commented on pull request #389: Issue #388 - Fix python driver build from source
Posted by GitBox <gi...@apache.org>.
Hunaid2000 commented on PR #389:
URL: https://github.com/apache/age/pull/389#issuecomment-1370571241
Yes works fine on my side with antlr4-python3-runtime v4.9.3 and other changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org