You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2022/05/03 18:21:57 UTC
[GitHub] [incubator-livy] praneetsharma opened a new pull request, #341: [LIVY-888] AddJar or AddFile call on a duplicate file should not result in failure for Livy session
praneetsharma opened a new pull request, #341:
URL: https://github.com/apache/incubator-livy/pull/341
## What changes were proposed in this pull request?
When a duplicate file is attempted to be added using LivyClient, duplicate file's addition is skipped and an appropriate warning is logged instead of the old behavior of throwing fatal IOException. This is now consistent with SparkContext's addJar and addFile APIs behavior.
https://issues.apache.org/jira/browse/LIVY-888
## How was this patch tested?
Modified the unit test TestSparkClient#testAddJarsAndFiles to attempt adding a duplicate file, and the test did not fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-livy] lmccay commented on pull request #341: [LIVY-888] AddJar or AddFile call on a duplicate file should not result in failure for Livy session
Posted by GitBox <gi...@apache.org>.
lmccay commented on PR #341:
URL: https://github.com/apache/incubator-livy/pull/341#issuecomment-1364561643
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-livy] jianzhenwu commented on pull request #341: [LIVY-888] AddJar or AddFile call on a duplicate file should not result in failure for Livy session
Posted by GitBox <gi...@apache.org>.
jianzhenwu commented on PR #341:
URL: https://github.com/apache/incubator-livy/pull/341#issuecomment-1312489534
Hi @praneetsharma , I think statement failure is acceptable and easy to be perceived by the user, not just a warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-livy] lmccay closed pull request #341: [LIVY-888] AddJar or AddFile call on a duplicate file should not result in failure for Livy session
Posted by GitBox <gi...@apache.org>.
lmccay closed pull request #341: [LIVY-888] AddJar or AddFile call on a duplicate file should not result in failure for Livy session
URL: https://github.com/apache/incubator-livy/pull/341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-livy] codecov-commenter commented on pull request #341: [LIVY-888] AddJar or AddFile call on a duplicate file should not result in failure for Livy session
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #341:
URL: https://github.com/apache/incubator-livy/pull/341#issuecomment-1364565640
# [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/341?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#341](https://codecov.io/gh/apache/incubator-livy/pull/341?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ebb6d63) into [master](https://codecov.io/gh/apache/incubator-livy/commit/4d8a912699683b973eee76d4e91447d769a0cb0d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4d8a912) will **decrease** coverage by `2.77%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #341 +/- ##
============================================
- Coverage 68.50% 65.72% -2.78%
+ Complexity 841 816 -25
============================================
Files 103 103
Lines 5940 5949 +9
Branches 898 899 +1
============================================
- Hits 4069 3910 -159
- Misses 1312 1513 +201
+ Partials 559 526 -33
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/341?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/341/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `79.66% <100.00%> (-1.17%)` | :arrow_down: |
| [...a/org/apache/livy/server/ThriftServerFactory.scala](https://codecov.io/gh/apache/incubator-livy/pull/341/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvVGhyaWZ0U2VydmVyRmFjdG9yeS5zY2FsYQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...main/scala/org/apache/livy/server/LivyServer.scala](https://codecov.io/gh/apache/incubator-livy/pull/341/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvTGl2eVNlcnZlci5zY2FsYQ==) | `2.23% <0.00%> (-29.47%)` | :arrow_down: |
| [...rc/main/scala/org/apache/livy/utils/SparkApp.scala](https://codecov.io/gh/apache/incubator-livy/pull/341/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9TcGFya0FwcC5zY2FsYQ==) | `56.00% <0.00%> (-20.00%)` | :arrow_down: |
| [core/src/main/scala/org/apache/livy/Logging.scala](https://codecov.io/gh/apache/incubator-livy/pull/341/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvTG9nZ2luZy5zY2FsYQ==) | `66.66% <0.00%> (-16.67%)` | :arrow_down: |
| [...e/livy/server/interactive/InteractiveSession.scala](https://codecov.io/gh/apache/incubator-livy/pull/341/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvaW50ZXJhY3RpdmUvSW50ZXJhY3RpdmVTZXNzaW9uLnNjYWxh) | `56.97% <0.00%> (-12.80%)` | :arrow_down: |
| [...src/main/scala/org/apache/livy/sessions/Kind.scala](https://codecov.io/gh/apache/incubator-livy/pull/341/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvc2Vzc2lvbnMvS2luZC5zY2FsYQ==) | `66.66% <0.00%> (-9.53%)` | :arrow_down: |
| [...la/org/apache/livy/utils/LineBufferedProcess.scala](https://codecov.io/gh/apache/incubator-livy/pull/341/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9MaW5lQnVmZmVyZWRQcm9jZXNzLnNjYWxh) | `78.57% <0.00%> (-7.15%)` | :arrow_down: |
| [...server/interactive/InteractiveSessionServlet.scala](https://codecov.io/gh/apache/incubator-livy/pull/341/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvaW50ZXJhY3RpdmUvSW50ZXJhY3RpdmVTZXNzaW9uU2VydmxldC5zY2FsYQ==) | `61.41% <0.00%> (-6.30%)` | :arrow_down: |
| [.../scala/org/apache/livy/server/SessionServlet.scala](https://codecov.io/gh/apache/incubator-livy/pull/341/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvU2Vzc2lvblNlcnZsZXQuc2NhbGE=) | `66.31% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [15 more](https://codecov.io/gh/apache/incubator-livy/pull/341/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-livy] lmccay merged pull request #341: [LIVY-888] AddJar or AddFile call on a duplicate file should not result in failure for Livy session
Posted by GitBox <gi...@apache.org>.
lmccay merged PR #341:
URL: https://github.com/apache/incubator-livy/pull/341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org