You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/21 18:19:35 UTC
[GitHub] [incubator-mxnet] haojin2 opened a new pull request #18129: Fix convenient method for np.sum
haojin2 opened a new pull request #18129:
URL: https://github.com/apache/incubator-mxnet/pull/18129
## Description ##
As title
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [ ] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments are documented.
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [x] Fix and test coverage
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18129: Fix convenient method for np.sum
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18129:
URL: https://github.com/apache/incubator-mxnet/pull/18129#issuecomment-617551428
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #18129: Fix convenient method for np.sum
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #18129:
URL: https://github.com/apache/incubator-mxnet/pull/18129#issuecomment-619104376
@haojjin2 this issue does also affect more people besides @sxjscience. Given there is no communication on the issue and the issue was blocking my work, I implemented a fix. Suggest you follow the best practice in the future..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] haojin2 commented on issue #18129: Fix convenient method for np.sum
Posted by GitBox <gi...@apache.org>.
haojin2 commented on issue #18129:
URL: https://github.com/apache/incubator-mxnet/pull/18129#issuecomment-617938350
@mxnet-bot run ci [all]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu edited a comment on pull request #18129: Fix convenient method for np.sum
Posted by GitBox <gi...@apache.org>.
leezu edited a comment on pull request #18129:
URL: https://github.com/apache/incubator-mxnet/pull/18129#issuecomment-619104376
@haojin2 this issue does also affect more people besides @sxjscience. Given there is no communication on the issue and the issue was blocking my work, I implemented a fix. Suggest you follow the best practice in the future..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18129: Fix convenient method for np.sum
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18129:
URL: https://github.com/apache/incubator-mxnet/pull/18129#issuecomment-617331529
Hey @haojin2 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [centos-gpu, windows-cpu, clang, windows-gpu, sanity, edge, centos-cpu, miscellaneous, unix-gpu, unix-cpu, website]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #18129: Fix convenient method for np.sum
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #18129:
URL: https://github.com/apache/incubator-mxnet/pull/18129#issuecomment-618801660
@haojin2 please link the issue you're fixing to avoid duplicate work https://github.com/apache/incubator-mxnet/pull/18152
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] haojin2 commented on issue #18129: Fix convenient method for np.sum
Posted by GitBox <gi...@apache.org>.
haojin2 commented on issue #18129:
URL: https://github.com/apache/incubator-mxnet/pull/18129#issuecomment-617551373
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] haojin2 commented on pull request #18129: Fix convenient method for np.sum
Posted by GitBox <gi...@apache.org>.
haojin2 commented on pull request #18129:
URL: https://github.com/apache/incubator-mxnet/pull/18129#issuecomment-618803003
I thought @sxjscience was well aware of this fix 2 days ago (he approved this PR 2 days ago), have you guys not synced at all on this issue? I guess maybe you need to communicate with issue author a bit before actually delivering a fix in the future ;-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18129: Fix convenient method for np.sum
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18129:
URL: https://github.com/apache/incubator-mxnet/pull/18129#issuecomment-617938492
Jenkins CI successfully triggered : [windows-cpu, windows-gpu, clang, unix-cpu, centos-gpu, miscellaneous, unix-gpu, website, centos-cpu, sanity, edge]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org