You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by zjffdu <gi...@git.apache.org> on 2016/06/07 08:03:08 UTC

[GitHub] spark pull request #13540: [SPARK-15788][PYSPARK][ML] PySpark IDFModel missi...

GitHub user zjffdu opened a pull request:

    https://github.com/apache/spark/pull/13540

    [SPARK-15788][PYSPARK][ML] PySpark IDFModel missing "idf" property

    ## What changes were proposed in this pull request?
    
    add method idf to IDF in pyspark
    
    
    ## How was this patch tested?
    
    add unit test 
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/spark SPARK-15788

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/13540.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13540
    
----
commit e5c11daa3a995bac6c99ec047b6a998c7ccdc895
Author: Jeff Zhang <zj...@apache.org>
Date:   2016-06-07T08:02:17Z

    [SPARK-15788][PYSPARK][ML] PySpark IDFModel missing "idf" property

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13540: [SPARK-15788][PYSPARK][ML] PySpark IDFModel missing "idf...

Posted by BryanCutler <gi...@git.apache.org>.

Github user BryanCutler commented on the issue:

    https://github.com/apache/spark/pull/13540
  
    Good catch!  Not too big of deal, but should this be a property?  Otherwise, LGTM
    cc @MLnick 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13540: [SPARK-15788][PYSPARK][ML] PySpark IDFModel missing "idf...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/13540
  
    **[Test build #60145 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60145/consoleFull)** for PR 13540 at commit [`d1c00da`](https://github.com/apache/spark/commit/d1c00da30601ca70f9f6385d532b5834aedb3182).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13540: [SPARK-15788][PYSPARK][ML] PySpark IDFModel missing "idf...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/13540
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60145/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13540: [SPARK-15788][PYSPARK][ML] PySpark IDFModel missing "idf...

Posted by MechCoder <gi...@git.apache.org>.

Github user MechCoder commented on the issue:

    https://github.com/apache/spark/pull/13540
  
    LGTM as well. pending the nitpick by @BryanCutler 
    
    Not related, but it's been a while since I hacked on Spark or PySpark but at some point do we need better docs for PySpark? I couldn't figure out how the IDF's are calculated without looking at the Scala documentation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13540: [SPARK-15788][PYSPARK][ML] PySpark IDFModel missing "idf...

Posted by MLnick <gi...@git.apache.org>.

Github user MLnick commented on the issue:

    https://github.com/apache/spark/pull/13540
  
    We should make it a property
    On Tue, 7 Jun 2016 at 11:28, Manoj Kumar <no...@github.com> wrote:
    
    > LGTM as well. pending the nitpick by @BryanCutler
    > <https://github.com/BryanCutler>
    >
    > Not related, but it's been a while since I hacked on Spark or PySpark but
    > at some point do we need better docs for PySpark? I couldn't figure out how
    > the IDF's are calculated without looking at the Scala documentation.
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/spark/pull/13540#issuecomment-224371061>, or mute
    > the thread
    > <https://github.com/notifications/unsubscribe/AA_SB_BQRxelQdfaS3wy5ld9p8efsmwnks5qJbhpgaJpZM4IvqPP>
    > .
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13540: [SPARK-15788][PYSPARK][ML] PySpark IDFModel missing "idf...

Posted by MLnick <gi...@git.apache.org>.

Github user MLnick commented on the issue:

    https://github.com/apache/spark/pull/13540
  
    Also, yes we should actually look at copying docs from Scala side where
    appropriate. We can add that to the QA JIRAs for Python doc.
    
    On Tue, 7 Jun 2016 at 11:28, Manoj Kumar <no...@github.com> wrote:
    
    > LGTM as well. pending the nitpick by @BryanCutler
    > <https://github.com/BryanCutler>
    >
    > Not related, but it's been a while since I hacked on Spark or PySpark but
    > at some point do we need better docs for PySpark? I couldn't figure out how
    > the IDF's are calculated without looking at the Scala documentation.
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/spark/pull/13540#issuecomment-224371061>, or mute
    > the thread
    > <https://github.com/notifications/unsubscribe/AA_SB_BQRxelQdfaS3wy5ld9p8efsmwnks5qJbhpgaJpZM4IvqPP>
    > .
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13540: [SPARK-15788][PYSPARK][ML] PySpark IDFModel missing "idf...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/13540
  
    **[Test build #60116 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60116/consoleFull)** for PR 13540 at commit [`e5c11da`](https://github.com/apache/spark/commit/e5c11daa3a995bac6c99ec047b6a998c7ccdc895).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13540: [SPARK-15788][PYSPARK][ML] PySpark IDFModel missing "idf...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/13540
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60116/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org