You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/17 14:56:11 UTC
[GitHub] [skywalking-banyandb] lujiajing1126 opened a new pull request, #194: Fix TopN sort direction issue and TopN query issue
lujiajing1126 opened a new pull request, #194:
URL: https://github.com/apache/skywalking-banyandb/pull/194
This PR fixes two issues,
1) Write TopN data with sort direction as a part of the entity,
2) Fix logic issue in the TopN query process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily merged pull request #194: Fix TopN sort direction issue and TopN query issue
Posted by GitBox <gi...@apache.org>.
hanahmily merged PR #194:
URL: https://github.com/apache/skywalking-banyandb/pull/194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] codecov-commenter commented on pull request #194: Fix TopN sort direction issue and TopN query issue
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #194:
URL: https://github.com/apache/skywalking-banyandb/pull/194#issuecomment-1281060295
# [Codecov](https://codecov.io/gh/apache/skywalking-banyandb/pull/194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#194](https://codecov.io/gh/apache/skywalking-banyandb/pull/194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c812c1) into [main](https://codecov.io/gh/apache/skywalking-banyandb/commit/df4abcfaaa313252ebe4b2262cafc54320389352?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (df4abcf) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #194 +/- ##
==========================================
- Coverage 44.57% 44.57% -0.01%
==========================================
Files 84 84
Lines 8381 8382 +1
==========================================
Hits 3736 3736
- Misses 4324 4325 +1
Partials 321 321
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking-banyandb/pull/194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [banyand/measure/measure\_topn.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC9tZWFzdXJlL21lYXN1cmVfdG9wbi5nbw==) | `23.89% <0.00%> (-0.06%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org