You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/02 08:27:49 UTC

[GitHub] [spark] Ngone51 commented on a change in pull request #32033: [SPARK-34939][CORE] Throw fetch failure exception when unable to deserialize broadcasted map statuses

Ngone51 commented on a change in pull request #32033:
URL: https://github.com/apache/spark/pull/32033#discussion_r606133973



##########
File path: core/src/main/scala/org/apache/spark/shuffle/FetchFailedException.scala
##########
@@ -68,5 +68,6 @@ private[spark] class FetchFailedException(
 private[spark] class MetadataFetchFailedException(
     shuffleId: Int,
     reduceId: Int,
-    message: String)
-  extends FetchFailedException(null, shuffleId, -1L, -1, reduceId, message)
+    message: String,
+    cause: Throwable = null)

Review comment:
       I don't see `cause` is used anywhere. Shall we covert the `cause` to stack string and append to the `message`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org