You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "ajantha-bhat (via GitHub)" <gi...@apache.org> on 2024/11/29 09:53:38 UTC

[PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

ajantha-bhat opened a new pull request, #11673:
URL: https://github.com/apache/iceberg/pull/11673

   Also update the naming from `iceberg-rest-adapter-image` -> `iceberg-rest-fixtures` in the docs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on code in PR #11673:
URL: https://github.com/apache/iceberg/pull/11673#discussion_r1876285651


##########
kafka-connect/kafka-connect-runtime/docker/docker-compose.yml:
##########
@@ -50,6 +50,7 @@ services:
     environment:
       - AWS_REGION=us-east-1
       - CATALOG_WAREHOUSE=s3://bucket/warehouse/
+      - CATALOG_URI=jdbc:sqlite:file:/tmp/iceberg_rest_mode=memory

Review Comment:
   Maybe the testcase is written such a way that, tables needs to be persisted. 
   Hence, it is passing with file based URI and failing with default URI. 
   
   Might have to refactor testcase. But locally I am not able to run these tests on MAC. 
   So, using the workaround. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #11673:
URL: https://github.com/apache/iceberg/pull/11673#issuecomment-2517194949

   @ajantha-bhat Go for it 🚀  https://hub.docker.com/repository/docker/apache/iceberg-rest-fixture/general


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on PR #11673:
URL: https://github.com/apache/iceberg/pull/11673#issuecomment-2538212669

   @Fokko: Anything else needed for this PR? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on code in PR #11673:
URL: https://github.com/apache/iceberg/pull/11673#discussion_r1876285651


##########
kafka-connect/kafka-connect-runtime/docker/docker-compose.yml:
##########
@@ -50,6 +50,7 @@ services:
     environment:
       - AWS_REGION=us-east-1
       - CATALOG_WAREHOUSE=s3://bucket/warehouse/
+      - CATALOG_URI=jdbc:sqlite:file:/tmp/iceberg_rest_mode=memory

Review Comment:
   Maybe the testcase is written such a way that, tables needs to be persisted. 
   Hence, it is passing with file based URI and failing with default URI (in-memory). 
   
   Might have to refactor testcase. But locally I am not able to run these tests on MAC. 
   So, using the workaround. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on PR #11673:
URL: https://github.com/apache/iceberg/pull/11673#issuecomment-2507462690

   waiting to publish image first to the dockerhub


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #11673:
URL: https://github.com/apache/iceberg/pull/11673#issuecomment-2516576543

   Pinged INFRA on the [ticket](https://issues.apache.org/jira/browse/INFRA-26275).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on PR #11673:
URL: https://github.com/apache/iceberg/pull/11673#issuecomment-2530527622

   Build has passed after changing the default URI to file based. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #11673:
URL: https://github.com/apache/iceberg/pull/11673#issuecomment-2507538087

   @ajantha-bhat Should we split out the renaming into a separate PR? I think it would be good to get that cleaned up ASAP. We can combine the rename with decoupling the user and the repository:
   
   https://github.com/apache/iceberg/blob/7c7b4bac9097217f5563338dbc4b30d1559b5d76/.github/workflows/publish-docker.yml#L51-L55
   
   We want to set the repository to `apache` instead of the user. If you're using a personal dockerhub account the username and the repository are the same, if you're using an organization, they are different.
   
   I think as part of the naming, we should also include `iceberg-rest-fixtures` in the name of the action:
   
   https://github.com/apache/iceberg/blob/7c7b4bac9097217f5563338dbc4b30d1559b5d76/.github/workflows/publish-docker.yml#L20


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #11673:
URL: https://github.com/apache/iceberg/pull/11673#issuecomment-2528160086

   Hmm, that's too bad. Let me check if it works on my machine


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat closed pull request #11673: REST: Use apache/iceberg-rest-fixture docker image
URL: https://github.com/apache/iceberg/pull/11673


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on PR #11673:
URL: https://github.com/apache/iceberg/pull/11673#issuecomment-2528139454

   @Fokko: The build is not passing. I figuring out :( 
   
   Locally I can't run it (has some other error). 
   
   That is why it is still in draft. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on PR #11673:
URL: https://github.com/apache/iceberg/pull/11673#issuecomment-2528510623

   @Fokko: Thanks for running locally. Kafka connect checks passed now after adding catalog URI.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #11673:
URL: https://github.com/apache/iceberg/pull/11673


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #11673:
URL: https://github.com/apache/iceberg/pull/11673#issuecomment-2528250190

   @ajantha-bhat I noticed that the docker-container is very old, can you try:
   
   ```
   --- a/kafka-connect/kafka-connect-runtime/docker/docker-compose.yml
   +++ b/kafka-connect/kafka-connect-runtime/docker/docker-compose.yml
   @@ -48,8 +48,12 @@ services:
        ports:
          - 8181:8181
        environment:
   +      - AWS_ACCESS_KEY_ID=admin
   +      - AWS_SECRET_ACCESS_KEY=password
          - AWS_REGION=us-east-1
          - CATALOG_WAREHOUSE=s3://bucket/warehouse/
   +      - CATALOG_CATALOG__IMPL=org.apache.iceberg.jdbc.JdbcCatalog
   +      - CATALOG_URI=jdbc:sqlite:file:/tmp/iceberg_rest_mode=memory
          - CATALOG_IO__IMPL=org.apache.iceberg.aws.s3.S3FileIO
          - CATALOG_S3_ENDPOINT=http://minio:9000
          - CATALOG_S3_PATH__STYLE__ACCESS=true
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #11673:
URL: https://github.com/apache/iceberg/pull/11673#issuecomment-2547782519

   @ajantha-bhat No, this looks great, it just fell off my radar :) Thanks for pinging me 👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] REST: Use apache/iceberg-rest-fixture docker image [iceberg]

Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on PR #11673:
URL: https://github.com/apache/iceberg/pull/11673#issuecomment-2517151164

   @Fokko: Thanks for pinged on the infra ticket, I saw that repo is created now 👍 
   
   I will rebase/retrigger this PR once we publish our docker image.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org