You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/04/07 21:10:21 UTC
[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request
#4608: Fix license issue
zrhoffman commented on a change in pull request #4608: Fix license issue
URL: https://github.com/apache/trafficcontrol/pull/4608#discussion_r405114947
##########
File path: .dependency_license
##########
@@ -31,6 +31,7 @@ RobotoSlab-Regular\.ttf$, Apache
\.config(\.example)?$, Apache
/\.bowerrc$, Apache
/\.jshintrc$, Apache
+/\.jshintignore$, Apache
Review comment:
No need to ignore this file. `.jshintignore` can have the Apache license at the top, prefixed with hashes (e.g., [like we do for dockerfiles](https://github.com/apache/trafficcontrol/blob/40934f3213/infrastructure/cdn-in-a-box/traffic_ops/Dockerfile#L1-L16)).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services