You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/23 05:02:24 UTC

[GitHub] [shardingsphere] kezhenxu94 commented on pull request #5765: download the wait-for-it.sh from github

kezhenxu94 commented on pull request #5765:
URL: https://github.com/apache/shardingsphere/pull/5765#issuecomment-632986069


   > BTW, @cherrylzhao do you think it is required to wget this third part file? What concerns me a bit is that we can not ensure this file exists there all the time, right?
   
   Yes agree, downloading from third-party repo may break someday if they're gone, or even when they have breaking changes, since you're always downloading the latest (master branch) codes, but for test purpose, I think it's OK to do so, yet it's better to lock the version, say https://raw.githubusercontent.com/vishnubob/wait-for-it/c096cface5fbd9f2d6b037391dfecae6fde1362e/wait-for-it.sh for example


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org