[GitHub] [calcite] vlsi commented on a change in pull request #1703: WIP: [CALCITE-2450] Reorder RexCall predicates to a canonical form

[GitBox <gi...@apache.org>]

vlsi commented on a change in pull request #1703: WIP: [CALCITE-2450] Reorder RexCall predicates to a canonical form
URL: https://github.com/apache/calcite/pull/1703#discussion_r361923755
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rex/RexCall.java
 ##########
 @@ -127,7 +143,23 @@ protected final StringBuilder appendOperands(StringBuilder sb) {
           includeType = RexDigestIncludeType.NO_TYPE;
         }
       }
-      sb.append(((RexLiteral) operand).computeDigest(includeType));
+      operandDigests.add(((RexLiteral) operand).computeDigest(includeType));
+    }
+    int totalLength = (operandDigests.size() - 1) * 2; // commas
+    for (String s : operandDigests) {
 
 Review comment:
   They must not be empty, because `AND()`, `=()` and so on means nothing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services