[GitHub] [inlong] haifxu commented on a diff in pull request #7808: [INLONG-7783][Agent] Support sink data tor Kafka

["haifxu (via GitHub)" <gi...@apache.org>]

haifxu commented on code in PR #7808:
URL: https://github.com/apache/inlong/pull/7808#discussion_r1161513365


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/AgentServiceImpl.java:
##########
@@ -518,6 +519,11 @@ private DataConfig getDataConfig(StreamSourceEntity entity, int op) {
                     topicConfig.setInlongGroupId(groupId);
                     topicConfig.setTopic(mqResource);
                     dataConfig.setTopicInfo(topicConfig);
+                } else if (MQType.KAFKA.equals(mqType)) {
+                    DataProxyTopicInfo topicConfig = new DataProxyTopicInfo();
+                    topicConfig.setInlongGroupId(groupId);
+                    topicConfig.setTopic(groupId + DOT + streamId);

Review Comment:
   Why not use `mqResource`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org