[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4313: [TE] Use multimap in metric urn as dimension

[GitBox <gi...@apache.org>]

jihaozh commented on a change in pull request #4313: [TE] Use multimap in metric urn as dimension
URL: https://github.com/apache/incubator-pinot/pull/4313#discussion_r293901786
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionUtils.java
 ##########
 @@ -55,8 +56,8 @@
   // TODO anomaly should support multimap
   public static DimensionMap toFilterMap(Multimap<String, String> filters) {
     DimensionMap map = new DimensionMap();
-    for (Map.Entry<String, String> entry : filters.entries()) {
-      map.put(entry.getKey(), entry.getValue());
+    for (Map.Entry<String, Collection<String>> entry: filters.asMap().entrySet()){
+      map.put(entry.getKey(), String.join(", ", entry.getValue()));
 
 Review comment:
   This dimension map is only used for presenting. Using ", " looks better than ",".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org