You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Evgeny Kotkov <ev...@visualsvn.com> on 2016/05/12 14:31:53 UTC

[PATCH] mod_http2, mod_proxy_http2: fix CMake support

I noticed a few issues in CMakeLists.txt that currently prevent building
mod_http2 and mod_proxy_http2 — that is, missing includes and library
references.

The attached patch should fix them.


Regards,
Evgeny Kotkov

Re: [PATCH] mod_http2, mod_proxy_http2: fix CMake support

Posted by Stefan Eissing <st...@greenbytes.de>.
Thanks Evgeny. Applied in trunk as r1743512.

To Jacob: mod_http2 should not be necessary as only OPTIONAL functions are used from it. mod_proxy_http2 is designed to work without mod_http2 being loaded (although it makes more sense if it is).

-Stefan

> Am 12.05.2016 um 16:54 schrieb Jacob Champion <ch...@gmail.com>:
> 
> On 05/12/2016 07:31 AM, Evgeny Kotkov wrote:
>> @@ -451,11 +452,11 @@
>>  SET(mod_proxy_wstunnel_extra_libs    mod_proxy)
>>  SET(mod_proxy_http2_requires               NGHTTP2_FOUND)
>>  SET(mod_proxy_http2_extra_defines          ssize_t=long)
>> -SET(mod_proxy_http2_extra_libs             ${NGHTTP2_LIBRARIES})
>> +SET(mod_proxy_http2_extra_includes         ${NGHTTP2_INCLUDE_DIR})
>> +SET(mod_proxy_http2_extra_libs             ${NGHTTP2_LIBRARIES} mod_proxy)
>>  SET(mod_proxy_http2_extra_sources
>>    modules/http2/h2_proxy_session.c   modules/http2/h2_util.c
>>  )
>> -SET(mod_proxy_http2_extra_libs       mod_proxy)
>>  SET(mod_ratelimit_extra_defines      AP_RL_DECLARE_EXPORT)
>>  SET(mod_sed_extra_sources
>>    modules/filters/regexp.c           modules/filters/sed0.c
> 
> +1 especially to the _extra_libs change (see also my prior attempt [1] at a patch for this). Should mod_http2 be added to the _extra_libs as well, or has that dependency been broken? The last time I took a look at this was in February, and I assume multiple things have changed since then.
> 
> I don't have Windows readily available to test this week, so I can't give a "works for me" yet.
> 
> --Jacob
> 
> [1] https://github.com/jchampio/httpd/commit/06edc06a42c8ccac5970cc7b4aa7cee84db346a2

Re: [PATCH] mod_http2, mod_proxy_http2: fix CMake support

Posted by Jacob Champion <ch...@gmail.com>.
On 05/12/2016 07:31 AM, Evgeny Kotkov wrote:
> @@ -451,11 +452,11 @@
>   SET(mod_proxy_wstunnel_extra_libs    mod_proxy)
>   SET(mod_proxy_http2_requires               NGHTTP2_FOUND)
>   SET(mod_proxy_http2_extra_defines          ssize_t=long)
> -SET(mod_proxy_http2_extra_libs             ${NGHTTP2_LIBRARIES})
> +SET(mod_proxy_http2_extra_includes         ${NGHTTP2_INCLUDE_DIR})
> +SET(mod_proxy_http2_extra_libs             ${NGHTTP2_LIBRARIES} mod_proxy)
>   SET(mod_proxy_http2_extra_sources
>     modules/http2/h2_proxy_session.c   modules/http2/h2_util.c
>   )
> -SET(mod_proxy_http2_extra_libs       mod_proxy)
>   SET(mod_ratelimit_extra_defines      AP_RL_DECLARE_EXPORT)
>   SET(mod_sed_extra_sources
>     modules/filters/regexp.c           modules/filters/sed0.c

+1 especially to the _extra_libs change (see also my prior attempt [1] 
at a patch for this). Should mod_http2 be added to the _extra_libs as 
well, or has that dependency been broken? The last time I took a look at 
this was in February, and I assume multiple things have changed since then.

I don't have Windows readily available to test this week, so I can't 
give a "works for me" yet.

--Jacob

[1] 
https://github.com/jchampio/httpd/commit/06edc06a42c8ccac5970cc7b4aa7cee84db346a2